Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(74)

Issue 2456483005: Treat bisect/tryjob perf test failures as warnings. (Closed)

Created:
4 years, 1 month ago by RobertoCN
Modified:
4 years, 1 month ago
Reviewers:
dtu, prasadv
CC:
chromium-reviews, infra-reviews+build_chromium.org, kjellander-cc_chromium.org
Target Ref:
refs/heads/master
Project:
build
Visibility:
Public.

Description

Treat bisect/tryjob perf test failures as warnings. This is so that they don't clutter the results of the bisect process. (Which can succeed even if some test runs fail) R=prasadv@chromium.org,dtu@chromium.org BUG=659800 Committed: https://chromium.googlesource.com/chromium/tools/build/+/72f7e3f630e0df6f08bd72f1ad112e5c1163a6e1

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+44 lines, -43 lines) Patch
M scripts/slave/recipe_modules/auto_bisect_staging/example.expected/failed_reference_range.json View 5 chunks +5 lines, -5 lines 0 comments Download
M scripts/slave/recipe_modules/auto_bisect_staging/example.expected/failed_revision.json View 5 chunks +5 lines, -5 lines 0 comments Download
M scripts/slave/recipe_modules/auto_bisect_staging/example.expected/return_code.json View 10 chunks +10 lines, -10 lines 0 comments Download
M scripts/slave/recipe_modules/bisect_tester_staging/perf_test.py View 1 chunk +1 line, -0 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect_staging.expected/failure_in_ref_range.json View 5 chunks +5 lines, -5 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect_staging.expected/local_basic_recipe_disconnected_device.json View 5 chunks +5 lines, -5 lines 0 comments Download
M scripts/slave/recipes/bisection/android_bisect_staging.expected/perf_tryjob_failed_test_android_fyi_perf_bisect.json View 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/bisection/android_bisect_staging.expected/perf_tryjob_failed_test_android_nexus5X_perf_bisect.json View 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/bisection/android_bisect_staging.expected/perf_tryjob_failed_test_android_nexus5_perf_bisect.json View 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/bisection/android_bisect_staging.expected/perf_tryjob_failed_test_android_nexus6_perf_bisect.json View 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/bisection/android_bisect_staging.expected/perf_tryjob_failed_test_android_nexus7_perf_bisect.json View 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/bisection/android_bisect_staging.expected/perf_tryjob_failed_test_android_nexus9_perf_bisect.json View 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/bisection/android_bisect_staging.expected/perf_tryjob_failed_test_android_one_perf_bisect.json View 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/bisection/android_bisect_staging.expected/perf_tryjob_failed_test_android_s5_perf_bisect.json View 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/bisection/android_bisect_staging.expected/perf_tryjob_failed_test_android_s5_perf_cq.json View 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/bisection/android_bisect_staging.expected/perf_tryjob_failed_test_android_webview_arm64_aosp_perf_bisect.json View 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/bisection/android_bisect_staging.expected/perf_tryjob_failed_test_android_webview_nexus6_aosp_perf_bisect.json View 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/bisection/android_bisect_staging.expected/perf_tryjob_failed_test_staging_android_nexus5X_perf_bisect.json View 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/bisection/desktop_bisect_staging.expected/perf_tryjob_failed_test.json View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (2 generated)
RobertoCN
4 years, 1 month ago (2016-10-26 21:27:07 UTC) #1
dtu
lgtm :)
4 years, 1 month ago (2016-10-26 23:02:08 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2456483005/1
4 years, 1 month ago (2016-10-27 06:06:27 UTC) #4
commit-bot: I haz the power
4 years, 1 month ago (2016-10-27 06:16:08 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/tools/build/+/72f7e3f630e0df6f08bd...

Powered by Google App Engine
This is Rietveld 408576698