 Chromium Code Reviews
 Chromium Code Reviews Issue 2456473002:
  Convert input-type-text.html with spellcheck_test  (Closed)
    
  
    Issue 2456473002:
  Convert input-type-text.html with spellcheck_test  (Closed) 
  | Index: third_party/WebKit/LayoutTests/editing/spelling/spellcheck_test.js | 
| diff --git a/third_party/WebKit/LayoutTests/editing/spelling/spellcheck_test.js b/third_party/WebKit/LayoutTests/editing/spelling/spellcheck_test.js | 
| index 994634b971daf1d1448377c6175ae5fc4dd593e5..7634b00a465c1f82757dbebd5fc86a39d034f6e8 100644 | 
| --- a/third_party/WebKit/LayoutTests/editing/spelling/spellcheck_test.js | 
| +++ b/third_party/WebKit/LayoutTests/editing/spelling/spellcheck_test.js | 
| @@ -208,6 +208,11 @@ class MarkerSerializer { | 
| Array.from(element.attributes) | 
| .sort((attr1, attr2) => attr1.name.localeCompare(attr2.name)) | 
| .forEach(attr => { | 
| + // Text form control elements' values need special handling. | 
| + if (isHTMLInputElement(element) || isHTMLTextAreaElement(element)) { | 
| 
yosin_UTC9
2016/10/27 01:44:46
nit: Please omit |isHTMLTextAreaElement()| since T
 | 
| + if (attr.name === 'value') | 
| + return; | 
| + } | 
| if (attr.value === '') | 
| return this.emit(` ${attr.name}`); | 
| const value = attr.value.replace(/&/g, '&') |