Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(10)

Unified Diff: third_party/WebKit/LayoutTests/editing/spelling/spellcheck_test.js

Issue 2456473002: Convert input-type-text.html with spellcheck_test (Closed)
Patch Set: Rename and remove expected text Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/LayoutTests/editing/spelling/spellcheck_test.js
diff --git a/third_party/WebKit/LayoutTests/editing/spelling/spellcheck_test.js b/third_party/WebKit/LayoutTests/editing/spelling/spellcheck_test.js
index 994634b971daf1d1448377c6175ae5fc4dd593e5..7634b00a465c1f82757dbebd5fc86a39d034f6e8 100644
--- a/third_party/WebKit/LayoutTests/editing/spelling/spellcheck_test.js
+++ b/third_party/WebKit/LayoutTests/editing/spelling/spellcheck_test.js
@@ -208,6 +208,11 @@ class MarkerSerializer {
Array.from(element.attributes)
.sort((attr1, attr2) => attr1.name.localeCompare(attr2.name))
.forEach(attr => {
+ // Text form control elements' values need special handling.
+ if (isHTMLInputElement(element) || isHTMLTextAreaElement(element)) {
yosin_UTC9 2016/10/27 01:44:46 nit: Please omit |isHTMLTextAreaElement()| since T
+ if (attr.name === 'value')
+ return;
+ }
if (attr.value === '')
return this.emit(` ${attr.name}`);
const value = attr.value.replace(/&/g, '&')

Powered by Google App Engine
This is Rietveld 408576698