Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(92)

Issue 2456473002: Convert input-type-text.html with spellcheck_test (Closed)

Created:
4 years, 1 month ago by Xiaocheng
Modified:
4 years, 1 month ago
Reviewers:
yosin_UTC9
CC:
blink-reviews, chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Convert input-type-text.html with spellcheck_test This patch converts editing/spelling/input-type-text.html with spellcheck_test as a preparation of implementing idle time spellchecker, and renames it to context_click_select_misspelling.html to better summarize the test case. The patch also contains a bug fix to spellcheck_test when handling the value attribute of INPUT and TEXTAREA. BUG=517298 Committed: https://crrev.com/e074c5dbded64330e973f64fa3c43c85a7f46687 Cr-Commit-Position: refs/heads/master@{#427968}

Patch Set 1 #

Patch Set 2 : Rename and remove expected text #

Total comments: 2

Patch Set 3 : Thu Oct 27 11:16:24 JST 2016 #

Patch Set 4 : Thu Oct 27 11:36:46 JST 2016 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+74 lines, -66 lines) Patch
A third_party/WebKit/LayoutTests/editing/spelling/context_click_select_misspelling.html View 1 2 3 1 chunk +69 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/editing/spelling/input-type-text.html View 1 1 chunk +0 lines, -53 lines 0 comments Download
D third_party/WebKit/LayoutTests/editing/spelling/input-type-text-expected.txt View 1 1 chunk +0 lines, -13 lines 0 comments Download
M third_party/WebKit/LayoutTests/editing/spelling/spellcheck_test.js View 1 2 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 28 (21 generated)
Xiaocheng
PTAL.
4 years, 1 month ago (2016-10-27 01:35:57 UTC) #11
yosin_UTC9
https://codereview.chromium.org/2456473002/diff/20001/third_party/WebKit/LayoutTests/editing/spelling/context_click_select_misspelling.html File third_party/WebKit/LayoutTests/editing/spelling/context_click_select_misspelling.html (right): https://codereview.chromium.org/2456473002/diff/20001/third_party/WebKit/LayoutTests/editing/spelling/context_click_select_misspelling.html#newcode33 third_party/WebKit/LayoutTests/editing/spelling/context_click_select_misspelling.html:33: () => assertContextClickSelection(input, 40, 'wellcome'), We should avoid a ...
4 years, 1 month ago (2016-10-27 01:44:46 UTC) #13
Xiaocheng
The build bots seem broken. Anyway, PTAL so that we don't get blocked.
4 years, 1 month ago (2016-10-27 07:26:49 UTC) #22
yosin_UTC9
lgtm
4 years, 1 month ago (2016-10-27 07:54:08 UTC) #24
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2456473002/60001
4 years, 1 month ago (2016-10-27 07:54:30 UTC) #25
commit-bot: I haz the power
Committed patchset #4 (id:60001)
4 years, 1 month ago (2016-10-27 08:52:58 UTC) #26
commit-bot: I haz the power
4 years, 1 month ago (2016-10-27 08:57:40 UTC) #28
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/e074c5dbded64330e973f64fa3c43c85a7f46687
Cr-Commit-Position: refs/heads/master@{#427968}

Powered by Google App Engine
This is Rietveld 408576698