Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(479)

Issue 2456463003: GN: Fix arm cross build to match gyp build (Closed)

Created:
4 years, 1 month ago by zra
Modified:
4 years, 1 month ago
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -5 lines) Patch
M build/toolchain/linux/BUILD.gn View 1 chunk +5 lines, -5 lines 0 comments Download
M tools/gn.py View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
zra
4 years, 1 month ago (2016-10-26 14:48:15 UTC) #2
Vyacheslav Egorov (Google)
lgtm
4 years, 1 month ago (2016-10-26 14:50:34 UTC) #3
zra
4 years, 1 month ago (2016-10-26 14:58:46 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
1ed9dc3ac00e09c6cd46a1a609de27bbe6306e42 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698