Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(125)

Issue 2456413002: Revert of Enable Site Isolation for Extensions. (Closed)

Created:
4 years, 1 month ago by nasko
Modified:
4 years, 1 month ago
Reviewers:
Devlin, alexmos
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org, site-isolation-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Enable Site Isolation for Extensions. (patchset #3 id:40001 of https://codereview.chromium.org/2285883002/ ) Reason for revert: Moving back to Site Isolation for Extensions being off by default, until we fix the remaining functional issues. Original issue's description: > Enable Site Isolation for Extensions. > > This CL enables isolated extensions. Removal of the command line flag and > the field trial will be done in a separate CL. > > BUG=545200 > > Committed: https://crrev.com/d8f0aefde00132b06bd97cb17555f2ec89a0c203 > Cr-Commit-Position: refs/heads/master@{#414879} TBR=alexmos@chromium.org,rdevlin.cronin@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=545200

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -3 lines) Patch
M chrome/browser/extensions/extension_apitest.cc View 1 chunk +4 lines, -1 line 0 comments Download
M chrome/common/extensions/extension_process_policy.cc View 1 chunk +10 lines, -1 line 0 comments Download
M extensions/browser/guest_view/web_view/web_view_apitest.cc View 1 chunk +4 lines, -1 line 0 comments Download

Messages

Total messages: 5 (2 generated)
nasko
Created Revert of Enable Site Isolation for Extensions.
4 years, 1 month ago (2016-10-28 18:05:39 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2456413002/1
4 years, 1 month ago (2016-10-28 18:06:00 UTC) #3
commit-bot: I haz the power
4 years, 1 month ago (2016-10-28 18:09:20 UTC) #5
Try jobs failed on following builders:
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)

Powered by Google App Engine
This is Rietveld 408576698