Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(683)

Issue 2456323002: Fix flag implications for --predictable. (Closed)

Created:
4 years, 1 month ago by ulan
Modified:
4 years, 1 month ago
Reviewers:
Michael Lippautz
CC:
v8-reviews_googlegroups.com, Michael Hablich
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Fix flag implications for --predictable. The order is important for DEFINE_IMPLICATION to ensure transitive implication: predictable => single_threaded => !concurrent_sweeping. BUG=5580 Committed: https://crrev.com/f2b60e9af26cd68bc40f91a040d448e663b9a87a Cr-Commit-Position: refs/heads/master@{#40644}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -7 lines) Patch
M src/flag-definitions.h View 2 chunks +8 lines, -7 lines 0 comments Download

Messages

Total messages: 11 (6 generated)
ulan
ptal
4 years, 1 month ago (2016-10-28 09:58:01 UTC) #3
Michael Lippautz
lgtm
4 years, 1 month ago (2016-10-28 12:21:31 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2456323002/1
4 years, 1 month ago (2016-10-28 12:24:50 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-10-28 12:50:26 UTC) #8
commit-bot: I haz the power
4 years, 1 month ago (2016-11-17 22:16:44 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/f2b60e9af26cd68bc40f91a040d448e663b9a87a
Cr-Commit-Position: refs/heads/master@{#40644}

Powered by Google App Engine
This is Rietveld 408576698