Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(119)

Issue 2456303003: Use Build.VERSION_CODES.N for detecting N in MediaNotification (Closed)

Created:
4 years, 1 month ago by Zhiqiang Zhang (Slow)
Modified:
4 years, 1 month ago
Reviewers:
whywhat
CC:
agrieve+watch_chromium.org, chromium-reviews, feature-media-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Use Build.VERSION_CODES.N for detecting N in MediaNotification BUG=645059 Committed: https://crrev.com/3125196f9265070d6eafbd31d8d8e3e04548ad4f Cr-Commit-Position: refs/heads/master@{#428403}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -3 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/media/ui/MediaNotificationManager.java View 1 chunk +1 line, -3 lines 0 comments Download

Messages

Total messages: 12 (7 generated)
Zhiqiang Zhang (Slow)
4 years, 1 month ago (2016-10-28 15:48:06 UTC) #3
whywhat
lgtm
4 years, 1 month ago (2016-10-28 16:39:46 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2456303003/1
4 years, 1 month ago (2016-10-28 17:09:33 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-10-28 17:16:18 UTC) #10
commit-bot: I haz the power
4 years, 1 month ago (2016-10-28 17:22:08 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/3125196f9265070d6eafbd31d8d8e3e04548ad4f
Cr-Commit-Position: refs/heads/master@{#428403}

Powered by Google App Engine
This is Rietveld 408576698