Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(14)

Issue 2456293003: Switch chrome.csi() to use times from WebPerformance. (Closed)

Created:
4 years, 1 month ago by Bryan McQuade
Modified:
4 years, 1 month ago
Reviewers:
Pat Meenan
CC:
chromium-apps-reviews_chromium.org, chromium-reviews, extensions-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Switch chrome.csi() to use times from WebPerformance. This is a follow on change to https://codereview.chromium.org/2084583002 which converted chrome.loadTimes() to use WebPerformance-based timings. The current chrome.csi() implementation uses the unsupported DocumentState-based metrics. startE, which is derived from DocumentState.request_time, has sometimes been reporting invalid values for the last 12 months due to crbug.com/615781. This change moves us to using data from a trusted/maintained/accurate data source. This change will also allow us to remove a few timing fields from DocumentState as part of a subsequent change. BUG=621512 Committed: https://crrev.com/a2b3e8c87b3f3372fc50ebd8a5e249995d1402ea Cr-Commit-Position: refs/heads/master@{#429018}

Patch Set 1 #

Patch Set 2 : report domcontentloaded value #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -13 lines) Patch
M chrome/renderer/loadtimes_extension_bindings.cc View 1 2 chunks +14 lines, -13 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 18 (13 generated)
Bryan McQuade
PTAL, thanks!
4 years, 1 month ago (2016-10-28 18:50:47 UTC) #5
Pat Meenan
LGTM
4 years, 1 month ago (2016-11-01 15:26:56 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2456293003/20001
4 years, 1 month ago (2016-11-01 15:30:22 UTC) #15
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 1 month ago (2016-11-01 16:35:37 UTC) #16
commit-bot: I haz the power
4 years, 1 month ago (2016-11-01 17:22:19 UTC) #18
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/a2b3e8c87b3f3372fc50ebd8a5e249995d1402ea
Cr-Commit-Position: refs/heads/master@{#429018}

Powered by Google App Engine
This is Rietveld 408576698