Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(334)

Issue 2456273002: Fix flaky ImeTest#testPasteLongText (Closed)

Created:
4 years, 1 month ago by yabinh
Modified:
4 years, 1 month ago
CC:
chromium-reviews, jam, darin-cc_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix flaky ImeTest#testPasteLongText ImeTest#testPasteLongText is flaky on low end devices because it takes too much time to copy very long text to the clipboard. We can set the content of clipboard directly to avoid flakiness. BUG=660312 Committed: https://crrev.com/0fe41db3e86f4046f07ac6d2e3f0598546a50d65 Cr-Commit-Position: refs/heads/master@{#428346}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -12 lines) Patch
M content/public/android/javatests/src/org/chromium/content/browser/input/ImeTest.java View 2 chunks +19 lines, -12 lines 0 comments Download

Messages

Total messages: 14 (9 generated)
yabinh
The failure rate is 5/20 on Android One. It becomes 0/100+ after applying this patch.
4 years, 1 month ago (2016-10-28 08:50:50 UTC) #5
Changwan Ryu
lgtm
4 years, 1 month ago (2016-10-28 09:37:33 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2456273002/1
4 years, 1 month ago (2016-10-28 12:40:52 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-10-28 12:46:30 UTC) #12
commit-bot: I haz the power
4 years, 1 month ago (2016-10-28 12:48:29 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/0fe41db3e86f4046f07ac6d2e3f0598546a50d65
Cr-Commit-Position: refs/heads/master@{#428346}

Powered by Google App Engine
This is Rietveld 408576698