Consolidate Android permissions prompt testing.

Consolidate Android permissions prompt testing.

This CL extracts the common methods and setup requirements from
GeolocationTest and MediaPermissionsTest into a new
PermissionTestCaseBase, and makes the two concrete tests inherit from
the test case base. This consolidates the UI testing for permission
prompts on Android and makes it easier to add new tests.

BUG=658125
Committed: https://crrev.com/ac471ccfa681f20e8d19db5728d62aae1b27f483
Cr-Commit-Position: refs/heads/master@{#429134}

[dominickn, 2016-10-28 04:52:51]

The CQ bit was checked by dominickn@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-28 04:53:15]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-28 04:55:41]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-28 04:55:42]

Dry run: Try jobs failed on following builders:
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[dominickn, 2016-10-28 04:59:01]

dominickn@chromium.org changed reviewers:
+ dfalcantara@chromium.org

[dominickn, 2016-10-28 04:59:02]

Hey Dan, WDYT? The tests won't run right until crrev.com/2446063002 lands (looks
like the file moving messes around with the bot update + dependency CL stuff).
This cleans up the prompt testing and should make adding new types of tests
really easy.

[dominickn, 2016-10-28 05:03:29]

Patchset #2 (id:20001) has been deleted

[dominickn, 2016-10-30 22:56:33]

The CQ bit was checked by dominickn@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-30 22:56:42]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-30 22:58:34]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-30 22:58:34]

Dry run: Try jobs failed on following builders:
  cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...)

[gone, 2016-10-31 23:46:58]

Looks a lot cleaner to me.

lgtm

https://codereview.chromium.org/2456243002/diff/60001/chrome/android/javatest...
File
chrome/android/javatests/src/org/chromium/chrome/browser/GeolocationTest.java
(left):

https://codereview.chromium.org/2456243002/diff/60001/chrome/android/javatest...
chrome/android/javatests/src/org/chromium/chrome/browser/GeolocationTest.java:375:
tab.removeObserver(updateWaiter);
Land of copypasta.

[dominickn, 2016-11-01 06:14:02]

The CQ bit was checked by dominickn@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-01 06:14:25]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[dominickn, 2016-11-01 07:00:31]

The CQ bit was checked by dominickn@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-01 07:00:52]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-01 07:59:15]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-01 07:59:16]

Dry run: This issue passed the CQ dry run.

[dominickn, 2016-11-01 08:27:24]

Thanks!

https://codereview.chromium.org/2456243002/diff/60001/chrome/android/javatest...
File
chrome/android/javatests/src/org/chromium/chrome/browser/GeolocationTest.java
(left):

https://codereview.chromium.org/2456243002/diff/60001/chrome/android/javatest...
chrome/android/javatests/src/org/chromium/chrome/browser/GeolocationTest.java:375:
tab.removeObserver(updateWaiter);
On 2016/10/31 23:46:57, dfalcantara (slow 10.24) wrote:
> Land of copypasta.

Ummm, since this is a deleted file I'll assume you're referring to how
repetitive this testing is. :)

[gone, 2016-11-01 16:43:31]

lgtm

https://codereview.chromium.org/2456243002/diff/60001/chrome/android/javatest...
File
chrome/android/javatests/src/org/chromium/chrome/browser/GeolocationTest.java
(left):

https://codereview.chromium.org/2456243002/diff/60001/chrome/android/javatest...
chrome/android/javatests/src/org/chromium/chrome/browser/GeolocationTest.java:375:
tab.removeObserver(updateWaiter);
On 2016/11/01 08:27:24, dominickn wrote:
> On 2016/10/31 23:46:57, dfalcantara (slow 10.24) wrote:
> > Land of copypasta.
> 
> Ummm, since this is a deleted file I'll assume you're referring to how
> repetitive this testing is. :)

Lol yeah... there usually isn't an incentive to refactor tests resulting in a
ton of copypasta for each new test.

[dominickn, 2016-11-01 22:14:58]

The CQ bit was checked by dominickn@chromium.org

[commit-bot: I haz the power, 2016-11-01 22:15:42]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-01 22:21:50]

Committed patchset #5 (id:100001)

[commit-bot: I haz the power, 2016-11-01 22:24:03]

Description was changed from

==========
Consolidate Android permissions prompt testing.

This CL extracts the common methods and setup requirements from
GeolocationTest and MediaPermissionsTest into a new
PermissionTestCaseBase, and makes the two concrete tests inherit from
the test case base. This consolidates the UI testing for permission
prompts on Android and makes it easier to add new tests.

BUG=658125
==========

to

==========
Consolidate Android permissions prompt testing.

This CL extracts the common methods and setup requirements from
GeolocationTest and MediaPermissionsTest into a new
PermissionTestCaseBase, and makes the two concrete tests inherit from
the test case base. This consolidates the UI testing for permission
prompts on Android and makes it easier to add new tests.

BUG=658125

Committed: https://crrev.com/ac471ccfa681f20e8d19db5728d62aae1b27f483
Cr-Commit-Position: refs/heads/master@{#429134}
==========

[commit-bot: I haz the power, 2016-11-01 22:24:04]

Patchset 5 (id:??) landed as
https://crrev.com/ac471ccfa681f20e8d19db5728d62aae1b27f483
Cr-Commit-Position: refs/heads/master@{#429134}