Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(265)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 245623005: Add missing scale value to fix SkGradientShader memory error (Closed)

Created:
6 years, 8 months ago by egdaniel
Modified:
6 years, 8 months ago
Reviewers:
bsalomon
CC:
skia-review_googlegroups.com
Base URL:
https://skia.googlesource.com/skia.git@master
Visibility:
Public.

Description

Add missing scale value to fix SkGradientShader memory error BUG=skia:2446 Committed: http://code.google.com/p/skia/source/detail?r=14291

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M src/effects/gradients/SkGradientShader.cpp View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
egdaniel
Valgrind errors went away on my local machine after this change
6 years, 8 months ago (2014-04-21 20:05:10 UTC) #1
bsalomon
lgtm
6 years, 8 months ago (2014-04-21 20:12:35 UTC) #2
egdaniel
The CQ bit was checked by egdaniel@google.com
6 years, 8 months ago (2014-04-21 20:14:10 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/egdaniel@google.com/245623005/1
6 years, 8 months ago (2014-04-21 20:14:16 UTC) #4
commit-bot: I haz the power
6 years, 8 months ago (2014-04-21 21:09:50 UTC) #5
Message was sent while issue was closed. 
Change committed as 14291

Powered by Google App Engine
This is Rietveld 408576698