Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(108)

Issue 2456203002: DevTools: Don't let the suggestbox overflow its bounds (Closed)

Created:
4 years, 1 month ago by einbinder
Modified:
4 years, 1 month ago
Reviewers:
dgozman
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

DevTools: Don't let the suggestbox overflow its bounds BUG=658685 Committed: https://crrev.com/beee5025a4557f5ea443e7583aa508a26d85ad3d Cr-Commit-Position: refs/heads/master@{#428516}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M third_party/WebKit/Source/devtools/front_end/ui/SuggestBox.js View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 12 (7 generated)
einbinder
ptal
4 years, 1 month ago (2016-10-27 23:21:58 UTC) #3
dgozman
lgtm
4 years, 1 month ago (2016-10-28 00:28:34 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2456203002/1
4 years, 1 month ago (2016-10-28 22:10:23 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-10-28 22:17:06 UTC) #10
commit-bot: I haz the power
4 years, 1 month ago (2016-10-28 22:20:24 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/beee5025a4557f5ea443e7583aa508a26d85ad3d
Cr-Commit-Position: refs/heads/master@{#428516}

Powered by Google App Engine
This is Rietveld 408576698