Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(94)

Issue 2456193006: Revert of [wasm] Support for restricted table imports. (Closed)

Created:
4 years, 1 month ago by Michael Achenbach
Modified:
4 years, 1 month ago
Reviewers:
titzer, bradnelson, rossberg
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of [wasm] Support for restricted table imports. (patchset #7 id:120001 of https://codereview.chromium.org/2454503005/ ) Reason for revert: GC stress failures: https://build.chromium.org/p/client.v8/builders/V8%20Linux64%20GC%20Stress%20-%20custom%20snapshot/builds/8857 Original issue's description: > [wasm] Support for restricted table imports. > > This CL implements basic table import functionality. > > Missing: growing of tables (WebAssembly.Grow) doesn't change dispatch tables > Missing: allowing larger table imports than minimum size > > R=rossberg@chromium.org,bradnelson@chromium.org > BUG=v8:5507 TBR=bradnelson@chromium.org,rossberg@chromium.org,titzer@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=v8:5507 Committed: https://crrev.com/bc0ee727df77e8382dacafd1774ceb3d7425417f Cr-Commit-Position: refs/heads/master@{#40656}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+349 lines, -826 lines) Patch
M src/compiler/wasm-compiler.h View 2 chunks +1 line, -2 lines 0 comments Download
M src/compiler/wasm-compiler.cc View 6 chunks +30 lines, -28 lines 0 comments Download
M src/wasm/module-decoder.cc View 7 chunks +46 lines, -28 lines 0 comments Download
M src/wasm/wasm-interpreter.cc View 3 chunks +8 lines, -2 lines 0 comments Download
M src/wasm/wasm-js.h View 1 chunk +6 lines, -15 lines 0 comments Download
M src/wasm/wasm-js.cc View 6 chunks +12 lines, -75 lines 0 comments Download
M src/wasm/wasm-module.h View 3 chunks +3 lines, -8 lines 0 comments Download
M src/wasm/wasm-module.cc View 27 chunks +232 lines, -373 lines 0 comments Download
M test/cctest/wasm/wasm-run-utils.h View 1 chunk +1 line, -3 lines 0 comments Download
M test/mjsunit/wasm/indirect-tables.js View 3 chunks +2 lines, -277 lines 0 comments Download
M test/mjsunit/wasm/wasm-module-builder.js View 2 chunks +0 lines, -12 lines 0 comments Download
M test/unittests/wasm/module-decoder-unittest.cc View 3 chunks +8 lines, -3 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
Michael Achenbach
Created Revert of [wasm] Support for restricted table imports.
4 years, 1 month ago (2016-10-28 18:58:23 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2456193006/1
4 years, 1 month ago (2016-10-28 18:58:26 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-10-28 18:58:40 UTC) #5
commit-bot: I haz the power
4 years, 1 month ago (2016-11-17 22:17:19 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/bc0ee727df77e8382dacafd1774ceb3d7425417f
Cr-Commit-Position: refs/heads/master@{#40656}

Powered by Google App Engine
This is Rietveld 408576698