Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Issue 2456193005: [stubs] Remove CSA::AssertInstanceType() in favour of CSA_ASSERT(HasInstanceType()). (Closed)

Created:
4 years, 1 month ago by Igor Sheludko
Modified:
4 years, 1 month ago
Reviewers:
Camillo Bruni
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[stubs] Remove CSA::AssertInstanceType() in favour of CSA_ASSERT(HasInstanceType()). ... because the latter unlike the former records meaningful position. BUG= Committed: https://crrev.com/3c2e3797505cc2253cb21b8803dcad0f6640fbd8 Cr-Commit-Position: refs/heads/master@{#40640}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -16 lines) Patch
M src/builtins/builtins-regexp.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M src/code-stub-assembler.h View 1 chunk +0 lines, -2 lines 0 comments Download
M src/code-stub-assembler.cc View 7 chunks +7 lines, -12 lines 0 comments Download

Messages

Total messages: 12 (7 generated)
Igor Sheludko
PTAL
4 years, 1 month ago (2016-10-28 07:36:34 UTC) #6
Camillo Bruni
LGTM
4 years, 1 month ago (2016-10-28 08:45:46 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2456193005/1
4 years, 1 month ago (2016-10-28 10:07:44 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-10-28 10:09:25 UTC) #10
commit-bot: I haz the power
4 years, 1 month ago (2016-11-17 22:16:32 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/3c2e3797505cc2253cb21b8803dcad0f6640fbd8
Cr-Commit-Position: refs/heads/master@{#40640}

Powered by Google App Engine
This is Rietveld 408576698