Image Capture: enable content_browsertests in Linux/CrOs

Image Capture: enable content_browsertests in Linux/CrOs,

This CL updates getUserMedia() constraint syntax, which
I suspect is part of the reason why sometimes these tests
have timed out (if the video resolution is too large, it
may very well jam the bot).

With that small update this CL enables the tests for
CrOs/Linux.

BUG=656810
Committed: https://crrev.com/92ebdcde2bc82bd548cce2222e2902b2d4ce6cd4
Cr-Commit-Position: refs/heads/master@{#428433}

[mcasas, 2016-10-27 22:47:53]

Description was changed from

==========
Image Capture: enable content_browsertests in Linux/CrOs, update getUserMedia()
constraint syntax

BUG=656810
==========

to

==========
Image Capture: enable content_browsertests in Linux/CrOs, 

This CL updates getUserMedia() constraint syntax, which
I suspect is part of the reason why sometimes these tests
have timed out (if the video resolution is too large, it 
may very well jam the bot).

With that small update this CL enables the tests for 
CrOs/Linux.


BUG=656810
==========

[mcasas, 2016-10-27 22:48:27]

mcasas@chromium.org changed reviewers:
+ xianglu@chromium.org

[mcasas, 2016-10-27 22:48:28]

xianglu@ PTAL

[mcasas, 2016-10-27 23:43:44]

The CQ bit was checked by mcasas@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-27 23:44:32]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-28 01:16:39]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-28 01:16:41]

Dry run: Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[xianglu, 2016-10-28 16:33:55]

https://codereview.chromium.org/2456193004/diff/1/content/browser/webrtc/webr...
File content/browser/webrtc/webrtc_image_capture_browsertest.cc (right):

https://codereview.chromium.org/2456193004/diff/1/content/browser/webrtc/webr...
content/browser/webrtc/webrtc_image_capture_browsertest.cc:49: };
Consider:
{
    {true},
#if !defined(OS_LINUX)
#else
    {false},
#endif
}
I think with the comma, if we need to modify this list in the future we only
need to change one line.

https://codereview.chromium.org/2456193004/diff/1/content/test/data/media/ima...
File content/test/data/media/image_capture_test.html (right):

https://codereview.chromium.org/2456193004/diff/1/content/test/data/media/ima...
content/test/data/media/image_capture_test.html:10: const constraints = { width:
{ max : WIDTH } };
/** @const */ var constraints = { width: { max : WIDTH } }? (I might be wrong
though.)

[mcasas, 2016-10-28 17:00:33]

The CQ bit was checked by mcasas@chromium.org to run a CQ dry run

[mcasas, 2016-10-28 17:00:49]

ptal

https://codereview.chromium.org/2456193004/diff/1/content/browser/webrtc/webr...
File content/browser/webrtc/webrtc_image_capture_browsertest.cc (right):

https://codereview.chromium.org/2456193004/diff/1/content/browser/webrtc/webr...
content/browser/webrtc/webrtc_image_capture_browsertest.cc:49: };
On 2016/10/28 16:33:54, xianglu wrote:
> Consider:
> {
>     {true},
> #if !defined(OS_LINUX)
> #else
>     {false},
> #endif
> }
> I think with the comma, if we need to modify this list in the future we only
> need to change one line.

I'm always wondering if some compilers would not
have issues with trailing commas after the last
element of an initializer lists, we'll see the bots,
otherwise done.

https://codereview.chromium.org/2456193004/diff/1/content/test/data/media/ima...
File content/test/data/media/image_capture_test.html (right):

https://codereview.chromium.org/2456193004/diff/1/content/test/data/media/ima...
content/test/data/media/image_capture_test.html:10: const constraints = { width:
{ max : WIDTH } };
On 2016/10/28 16:33:55, xianglu wrote:
> /** @const */ var constraints = { width: { max : WIDTH } }? (I might be wrong
> though.)

Done.

[commit-bot: I haz the power, 2016-10-28 17:00:54]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[xianglu, 2016-10-28 17:04:11]

lgtm.

[mcasas, 2016-10-28 17:15:20]

mcasas@chromium.org changed reviewers:
+ avi@chromium.org

[mcasas, 2016-10-28 17:15:21]

avi@ plz RS the content browsertest change, thx!

[Avi (use Gerrit), 2016-10-28 17:39:38]

lgtm

stampity stamp

[commit-bot: I haz the power, 2016-10-28 18:03:32]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-28 18:03:33]

Dry run: This issue passed the CQ dry run.

[mcasas, 2016-10-28 18:22:09]

The CQ bit was checked by mcasas@chromium.org

[commit-bot: I haz the power, 2016-10-28 18:22:41]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-28 18:28:43]

Description was changed from

==========
Image Capture: enable content_browsertests in Linux/CrOs, 

This CL updates getUserMedia() constraint syntax, which
I suspect is part of the reason why sometimes these tests
have timed out (if the video resolution is too large, it 
may very well jam the bot).

With that small update this CL enables the tests for 
CrOs/Linux.


BUG=656810
==========

to

==========
Image Capture: enable content_browsertests in Linux/CrOs, 

This CL updates getUserMedia() constraint syntax, which
I suspect is part of the reason why sometimes these tests
have timed out (if the video resolution is too large, it 
may very well jam the bot).

With that small update this CL enables the tests for 
CrOs/Linux.


BUG=656810
==========

[commit-bot: I haz the power, 2016-10-28 18:28:44]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-10-28 18:38:21]

Description was changed from

==========
Image Capture: enable content_browsertests in Linux/CrOs, 

This CL updates getUserMedia() constraint syntax, which
I suspect is part of the reason why sometimes these tests
have timed out (if the video resolution is too large, it 
may very well jam the bot).

With that small update this CL enables the tests for 
CrOs/Linux.


BUG=656810
==========

to

==========
Image Capture: enable content_browsertests in Linux/CrOs,

This CL updates getUserMedia() constraint syntax, which
I suspect is part of the reason why sometimes these tests
have timed out (if the video resolution is too large, it
may very well jam the bot).

With that small update this CL enables the tests for
CrOs/Linux.

BUG=656810

Committed: https://crrev.com/92ebdcde2bc82bd548cce2222e2902b2d4ce6cd4
Cr-Commit-Position: refs/heads/master@{#428433}
==========

[commit-bot: I haz the power, 2016-10-28 18:38:22]

Patchset 2 (id:??) landed as
https://crrev.com/92ebdcde2bc82bd548cce2222e2902b2d4ce6cd4
Cr-Commit-Position: refs/heads/master@{#428433}