[Offline Pages] Fix official build failure (using clang) caused by unused variables.

[Offline Pages] Fix official build failure caused by unused variables.

Official build would fail since there'll be unused variables. Guarding
by the same flag used in the file would fix the issue.

BUG=660169
Committed: https://crrev.com/4788453d9c646d7330cf0668739e2f923600101d
Cr-Commit-Position: refs/heads/master@{#428791}

[romax, 2016-10-27 21:48:59]

romax@chromium.org changed reviewers:
+ dewittj@chromium.org

[romax, 2016-10-27 21:48:59]

PTAL! Thanks!

[dewittj, 2016-10-27 22:09:51]

https://codereview.chromium.org/2456173002/diff/1/chrome/browser/android/offl...
File chrome/browser/android/offline_pages/request_coordinator_factory.cc
(right):

https://codereview.chromium.org/2456173002/diff/1/chrome/browser/android/offl...
chrome/browser/android/offline_pages/request_coordinator_factory.cc:37: #if
!defined(OFFICIAL_BUILD)
Please add a comment here, and ideally a todo like:

TODO(romax): Refactor test-harness specific variables into test-harness specific
files.

When that's done, these constants can be included or not based on GN rules
rather than #ifdefs.

[romax, 2016-10-28 00:04:07]

cleaned the request_coordinator_factory.cc and it should not have any code
guarded by flag.
PTAL, thanks!

[romax, 2016-10-31 19:55:12]

ping. PTAL, thanks!

[dewittj, 2016-10-31 19:57:38]

lgtm, thanks!

[romax, 2016-10-31 19:58:51]

The CQ bit was checked by romax@chromium.org

[commit-bot: I haz the power, 2016-10-31 19:59:28]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-31 20:34:00]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-10-31 20:38:17]

Description was changed from

==========
[Offline Pages] Fix official build failure caused by unused variables.

Official build would fail since there'll be unused variables. Guarding
by the same flag used in the file would fix the issue.

BUG=660169
==========

to

==========
[Offline Pages] Fix official build failure caused by unused variables.

Official build would fail since there'll be unused variables. Guarding
by the same flag used in the file would fix the issue.

BUG=660169

Committed: https://crrev.com/4788453d9c646d7330cf0668739e2f923600101d
Cr-Commit-Position: refs/heads/master@{#428791}
==========

[commit-bot: I haz the power, 2016-10-31 20:38:18]

Patchset 2 (id:??) landed as
https://crrev.com/4788453d9c646d7330cf0668739e2f923600101d
Cr-Commit-Position: refs/heads/master@{#428791}