Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(312)

Issue 2456173002: [Offline Pages] Fix official build failure (using clang) caused by unused variables. (Closed)

Created:
4 years, 1 month ago by romax
Modified:
4 years, 1 month ago
Reviewers:
dewittj
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Offline Pages] Fix official build failure caused by unused variables. Official build would fail since there'll be unused variables. Guarding by the same flag used in the file would fix the issue. BUG=660169 Committed: https://crrev.com/4788453d9c646d7330cf0668739e2f923600101d Cr-Commit-Position: refs/heads/master@{#428791}

Patch Set 1 #

Total comments: 1

Patch Set 2 : [Offline Pages] Fix official build failure. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+71 lines, -64 lines) Patch
M chrome/browser/android/offline_pages/evaluation/offline_page_evaluation_bridge.h View 1 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/android/offline_pages/evaluation/offline_page_evaluation_bridge.cc View 1 4 chunks +69 lines, -1 line 0 comments Download
M chrome/browser/android/offline_pages/request_coordinator_factory.h View 1 1 chunk +0 lines, -4 lines 0 comments Download
M chrome/browser/android/offline_pages/request_coordinator_factory.cc View 1 1 chunk +0 lines, -59 lines 0 comments Download

Messages

Total messages: 11 (3 generated)
romax
PTAL! Thanks!
4 years, 1 month ago (2016-10-27 21:48:59 UTC) #2
dewittj
https://codereview.chromium.org/2456173002/diff/1/chrome/browser/android/offline_pages/request_coordinator_factory.cc File chrome/browser/android/offline_pages/request_coordinator_factory.cc (right): https://codereview.chromium.org/2456173002/diff/1/chrome/browser/android/offline_pages/request_coordinator_factory.cc#newcode37 chrome/browser/android/offline_pages/request_coordinator_factory.cc:37: #if !defined(OFFICIAL_BUILD) Please add a comment here, and ideally ...
4 years, 1 month ago (2016-10-27 22:09:51 UTC) #3
romax
cleaned the request_coordinator_factory.cc and it should not have any code guarded by flag. PTAL, thanks!
4 years, 1 month ago (2016-10-28 00:04:07 UTC) #4
romax
ping. PTAL, thanks!
4 years, 1 month ago (2016-10-31 19:55:12 UTC) #5
dewittj
lgtm, thanks!
4 years, 1 month ago (2016-10-31 19:57:38 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2456173002/20001
4 years, 1 month ago (2016-10-31 19:59:28 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 1 month ago (2016-10-31 20:34:00 UTC) #9
commit-bot: I haz the power
4 years, 1 month ago (2016-10-31 20:38:18 UTC) #11
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/4788453d9c646d7330cf0668739e2f923600101d
Cr-Commit-Position: refs/heads/master@{#428791}

Powered by Google App Engine
This is Rietveld 408576698