Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3160)

Unified Diff: base/containers/scoped_ptr_hash_map.h

Issue 2456163002: Remove stl_util's STLDeleteContainerPointers. (Closed)
Patch Set: last few Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « PRESUBMIT.py ('k') | base/memory/scoped_vector.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: base/containers/scoped_ptr_hash_map.h
diff --git a/base/containers/scoped_ptr_hash_map.h b/base/containers/scoped_ptr_hash_map.h
index 03f25c5b637199e2d5374f09ca75f5185c2e0163..72c6ff4152e2d03bc77abe60fc6384dac0c18339 100644
--- a/base/containers/scoped_ptr_hash_map.h
+++ b/base/containers/scoped_ptr_hash_map.h
@@ -128,9 +128,9 @@ class ScopedPtrHashMap {
inline void clear() {
auto it = data_.begin();
while (it != data_.end()) {
- // NOTE: Like STLDeleteContainerPointers, deleting behind the iterator.
- // Deleting the value does not always invalidate the iterator, but it may
- // do so if the key is a pointer into the value object.
+ // NOTE: Deleting behind the iterator. Deleting the value does not always
+ // invalidate the iterator, but it may do so if the key is a pointer into
+ // the value object.
auto temp = it;
++it;
// Let ScopedPtr decide how to delete.
« no previous file with comments | « PRESUBMIT.py ('k') | base/memory/scoped_vector.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698