Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(127)

Issue 2456143002: Switch Android Compile to the chromium recipe (Closed)

Created:
4 years, 1 month ago by martiniss
Modified:
4 years, 1 month ago
CC:
chromium-reviews, infra-reviews+build_chromium.org
Target Ref:
refs/heads/master
Project:
build
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -4 lines) Patch
M masters/master.chromium.perf/master.cfg View 2 chunks +4 lines, -4 lines 2 comments Download

Messages

Total messages: 8 (3 generated)
martiniss
PTAL
4 years, 1 month ago (2016-10-27 20:24:01 UTC) #2
ghost stip (do not use)
lgtm please get dtu@ or someone on speed-infra to confirm https://codereview.chromium.org/2456143002/diff/1/masters/master.chromium.perf/master.cfg File masters/master.chromium.perf/master.cfg (right): https://codereview.chromium.org/2456143002/diff/1/masters/master.chromium.perf/master.cfg#newcode123 ...
4 years, 1 month ago (2016-10-28 18:42:22 UTC) #3
dtu
lgtm https://codereview.chromium.org/2456143002/diff/1/masters/master.chromium.perf/master.cfg File masters/master.chromium.perf/master.cfg (right): https://codereview.chromium.org/2456143002/diff/1/masters/master.chromium.perf/master.cfg#newcode123 masters/master.chromium.perf/master.cfg:123: bb_trigger = True On 2016/10/28 18:42:22, stip wrote: ...
4 years, 1 month ago (2016-10-28 19:08:58 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2456143002/1
4 years, 1 month ago (2016-10-28 19:51:19 UTC) #6
commit-bot: I haz the power
4 years, 1 month ago (2016-10-28 20:06:00 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/tools/build/+/6c76598af3049582f44b...

Powered by Google App Engine
This is Rietveld 408576698