Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1286)

Unified Diff: third_party/WebKit/Source/core/paint/PaintPropertyTreeBuilder.h

Issue 2456113002: Separate property and context updates in PaintPropertyTreeBuilder (Closed)
Patch Set: Cleanup names/comments, fix preserves3d bug Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/paint/PaintPropertyTreeBuilder.h
diff --git a/third_party/WebKit/Source/core/paint/PaintPropertyTreeBuilder.h b/third_party/WebKit/Source/core/paint/PaintPropertyTreeBuilder.h
index 88b7f0127e81e629468b821ec2e872c4b6e3d1bf..8e41a534e1d9bbe05281c99aba298b8268382b27 100644
--- a/third_party/WebKit/Source/core/paint/PaintPropertyTreeBuilder.h
+++ b/third_party/WebKit/Source/core/paint/PaintPropertyTreeBuilder.h
@@ -83,11 +83,18 @@ struct PaintPropertyTreeBuilderContext {
class PaintPropertyTreeBuilder {
public:
PaintPropertyTreeBuilderContext setupInitialContext();
- void buildTreeNodes(FrameView&, PaintPropertyTreeBuilderContext&);
- void buildTreeNodesForSelf(const LayoutObject&,
- PaintPropertyTreeBuilderContext&);
- void buildTreeNodesForChildren(const LayoutObject&,
- PaintPropertyTreeBuilderContext&);
+ // Update the paint properties for |FrameView| and ensure the context is
+ // up to date.
+ void updatePropertiesAndContext(FrameView&, PaintPropertyTreeBuilderContext&);
+
+ // Update the paint properties that affect this object (e.g., properties like
+ // paint offset translation) and ensure the context is up to date.
+ void updatePropertiesAndContextForSelf(const LayoutObject&,
+ PaintPropertyTreeBuilderContext&);
+ // Update the paint properties that affect children of this object (e.g.,
+ // scroll offset transform) and ensure the context is up to date.
+ void updatePropertiesAndContextForChildren(const LayoutObject&,
+ PaintPropertyTreeBuilderContext&);
private:
static void updatePaintOffsetTranslation(const LayoutObject&,

Powered by Google App Engine
This is Rietveld 408576698