Separate property and context updates in PaintPropertyTreeBuilder

third_party/WebKit/Source/core/paint/ObjectPaintProperties.h

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef ObjectPaintProperties_h
 #define ObjectPaintProperties_h
 
 #include "core/CoreExport.h"
 #include "platform/geometry/LayoutPoint.h"
 #include "platform/graphics/paint/ClipPaintPropertyNode.h"
@@ skipping 125 matching lines @@
   // invalidation.
   ObjectPaintProperties::PropertyTreeStateWithOffset contentsProperties() const;
 
   void clearPaintOffsetTranslation() { m_paintOffsetTranslation = nullptr; }
   void clearTransform() { m_transform = nullptr; }
   void clearEffect() { m_effect = nullptr; }
   void clearCssClip() { m_cssClip = nullptr; }
   void clearCssClipFixedPosition() { m_cssClipFixedPosition = nullptr; }
   void clearInnerBorderRadiusClip() { m_innerBorderRadiusClip = nullptr; }
   void clearOverflowClip() { m_overflowClip = nullptr; }
+  void clearLocalBorderBoxProperties() { m_localBorderBoxProperties = nullptr; }
   void clearPerspective() { m_perspective = nullptr; }
   void clearSvgLocalToBorderBoxTransform() {
     m_svgLocalToBorderBoxTransform = nullptr;
   }
   void clearScrollTranslation() { m_scrollTranslation = nullptr; }
   void clearScrollbarPaintOffset() { m_scrollbarPaintOffset = nullptr; }
   void clearScroll() { m_scroll = nullptr; }
 
   template <typename... Args>
-  TransformPaintPropertyNode* updatePaintOffsetTranslation(Args&&... args) {
-    return updateProperty(m_paintOffsetTranslation,
-                          std::forward<Args>(args)...);
+  void updatePaintOffsetTranslation(Args&&... args) {
+    updateProperty(m_paintOffsetTranslation, std::forward<Args>(args)...);
   }
   template <typename... Args>
-  TransformPaintPropertyNode* updateTransform(Args&&... args) {
-    return updateProperty(m_transform, std::forward<Args>(args)...);
+  void updateTransform(Args&&... args) {
+    updateProperty(m_transform, std::forward<Args>(args)...);
   }
   template <typename... Args>
-  TransformPaintPropertyNode* updatePerspective(Args&&... args) {
-    return updateProperty(m_perspective, std::forward<Args>(args)...);
+  void updatePerspective(Args&&... args) {
+    updateProperty(m_perspective, std::forward<Args>(args)...);
   }
   template <typename... Args>
-  TransformPaintPropertyNode* updateSvgLocalToBorderBoxTransform(
-      Args&&... args) {
+  void updateSvgLocalToBorderBoxTransform(Args&&... args) {
     DCHECK(!scrollTranslation()) << "SVG elements cannot scroll so there "
                                     "should never be both a scroll translation "
                                     "and an SVG local to border box transform.";
-    return updateProperty(m_svgLocalToBorderBoxTransform,
-                          std::forward<Args>(args)...);
+    updateProperty(m_svgLocalToBorderBoxTransform, std::forward<Args>(args)...);
   }
   template <typename... Args>
-  TransformPaintPropertyNode* updateScrollTranslation(Args&&... args) {
+  void updateScrollTranslation(Args&&... args) {
     DCHECK(!svgLocalToBorderBoxTransform())
         << "SVG elements cannot scroll so there should never be both a scroll "
            "translation and an SVG local to border box transform.";
-    return updateProperty(m_scrollTranslation, std::forward<Args>(args)...);
+    updateProperty(m_scrollTranslation, std::forward<Args>(args)...);
   }
   template <typename... Args>
-  TransformPaintPropertyNode* updateScrollbarPaintOffset(Args&&... args) {
-    return updateProperty(m_scrollbarPaintOffset, std::forward<Args>(args)...);
+  void updateScrollbarPaintOffset(Args&&... args) {
+    updateProperty(m_scrollbarPaintOffset, std::forward<Args>(args)...);
   }
   template <typename... Args>
-  ScrollPaintPropertyNode* updateScroll(Args&&... args) {
-    return updateProperty(m_scroll, std::forward<Args>(args)...);
+  void updateScroll(Args&&... args) {
+    updateProperty(m_scroll, std::forward<Args>(args)...);
   }
   template <typename... Args>
-  EffectPaintPropertyNode* updateEffect(Args&&... args) {
-    return updateProperty(m_effect, std::forward<Args>(args)...);
+  void updateEffect(Args&&... args) {
+    updateProperty(m_effect, std::forward<Args>(args)...);
   }
   template <typename... Args>
-  ClipPaintPropertyNode* updateCssClip(Args&&... args) {
-    return updateProperty(m_cssClip, std::forward<Args>(args)...);
+  void updateCssClip(Args&&... args) {
+    updateProperty(m_cssClip, std::forward<Args>(args)...);
   }
   template <typename... Args>
-  ClipPaintPropertyNode* updateCssClipFixedPosition(Args&&... args) {
-    return updateProperty(m_cssClipFixedPosition, std::forward<Args>(args)...);
+  void updateCssClipFixedPosition(Args&&... args) {
+    updateProperty(m_cssClipFixedPosition, std::forward<Args>(args)...);
   }
   template <typename... Args>
-  ClipPaintPropertyNode* updateInnerBorderRadiusClip(Args&&... args) {
-    return updateProperty(m_innerBorderRadiusClip, std::forward<Args>(args)...);
+  void updateInnerBorderRadiusClip(Args&&... args) {
+    updateProperty(m_innerBorderRadiusClip, std::forward<Args>(args)...);
   }
   template <typename... Args>
-  ClipPaintPropertyNode* updateOverflowClip(Args&&... args) {
-    return updateProperty(m_overflowClip, std::forward<Args>(args)...);
+  void updateOverflowClip(Args&&... args) {
+    updateProperty(m_overflowClip, std::forward<Args>(args)...);
   }
 
  private:
   ObjectPaintProperties() {}
 
   template <typename PaintPropertyNode, typename... Args>
-  PaintPropertyNode* updateProperty(RefPtr<PaintPropertyNode>& field,
-                                    Args&&... args) {
+  void updateProperty(RefPtr<PaintPropertyNode>& field, Args&&... args) {
     if (field)
       field->update(std::forward<Args>(args)...);
     else
       field = PaintPropertyNode::create(std::forward<Args>(args)...);
-    return field.get();
   }
 
   RefPtr<TransformPaintPropertyNode> m_paintOffsetTranslation;
   RefPtr<TransformPaintPropertyNode> m_transform;
   RefPtr<EffectPaintPropertyNode> m_effect;
   RefPtr<ClipPaintPropertyNode> m_cssClip;
   RefPtr<ClipPaintPropertyNode> m_cssClipFixedPosition;
   RefPtr<ClipPaintPropertyNode> m_innerBorderRadiusClip;
   RefPtr<ClipPaintPropertyNode> m_overflowClip;
   RefPtr<TransformPaintPropertyNode> m_perspective;
   // TODO(pdr): Only LayoutSVGRoot needs this and it should be moved there.
   RefPtr<TransformPaintPropertyNode> m_svgLocalToBorderBoxTransform;
   RefPtr<TransformPaintPropertyNode> m_scrollTranslation;
   RefPtr<TransformPaintPropertyNode> m_scrollbarPaintOffset;
   RefPtr<ScrollPaintPropertyNode> m_scroll;
 
   std::unique_ptr<PropertyTreeStateWithOffset> m_localBorderBoxProperties;
 };
 
 }  // namespace blink
 
 #endif  // ObjectPaintProperties_h