Issue 24561002: Fix replaying of HCapturedObject for nested objects.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 24561002: Fix replaying of HCapturedObject for nested objects. (Closed)

Created:
7 years, 2 months ago by Michael Starzinger

Modified:
7 years, 2 months ago

Reviewers:
titzer

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Fix replaying of HCapturedObject for nested objects. R=titzer@chromium.org TEST=mjsunit/compiler/property-refs,mjsunit/compiler/escape-analysis Committed: http://code.google.com/p/v8/source/detail?r=16969

Patch Set 1 #

Patch Set 2 : Add targeted regression test. #

Created: 7 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+46 lines, -7 lines)			Patch
	M	src/hydrogen-instructions.cc	View		1 chunk	+16 lines, -7 lines	0 comments	Download
	M	test/mjsunit/compiler/escape-analysis.js	View	1	1 chunk	+30 lines, -0 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

titzer

On 2013/09/25 11:13:31, Michael Starzinger wrote: You got tests?

7 years, 2 months ago (2013-09-26 10:00:35 UTC) #2

Michael Starzinger

As mentioned offline: With https://codereview.chromium.org/23533003/ applied mjsunit/compiler/property-refs starts failing. This bug cannot be triggered without ...

7 years, 2 months ago (2013-09-26 10:31:55 UTC) #3

titzer

On 2013/09/26 15:16:04, Michael Starzinger wrote: > Added test case. PTAL. LGTM

7 years, 2 months ago (2013-09-26 15:19:17 UTC) #5

Michael Starzinger

7 years, 2 months ago (2013-09-26 15:28:55 UTC) #6

Message was sent while issue was closed.

Committed patchset #2 manually as r16969 (presubmit successful).

Expand Messages | Collapse Messages