Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1443)

Unified Diff: cc/blimp/layer_tree_host_remote.cc

Issue 2456093003: Enable more layer_tree_host_unittest for LayerTreeHostRemote. (Closed)
Patch Set: PushPropertiesCountingLayer refactored for remote test. Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « cc/blimp/layer_factory.h ('k') | cc/layers/layer.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: cc/blimp/layer_tree_host_remote.cc
diff --git a/cc/blimp/layer_tree_host_remote.cc b/cc/blimp/layer_tree_host_remote.cc
index 56418c88418a2725a4e77caa8a73e0f68c70bffc..3e94aac020223c6af259e7941ed01c40fd4543bb 100644
--- a/cc/blimp/layer_tree_host_remote.cc
+++ b/cc/blimp/layer_tree_host_remote.cc
@@ -487,10 +487,13 @@ void LayerTreeHostRemote::SerializeCurrentState(
inputs_only);
// Serialize the dirty layers.
- for (auto* layer : layer_tree_->LayersThatShouldPushProperties())
+ std::unordered_set<Layer*> layers_need_push_properties;
+ layers_need_push_properties.swap(
+ layer_tree_->LayersThatShouldPushProperties());
Khushal 2016/10/28 23:11:50 Do you mind adding a small test for this in layer_
xingliu 2016/10/31 18:48:05 Done, make sense. Also tweak UpdateTrackingRemoteC
+
+ for (auto* layer : layers_need_push_properties)
layer->ToLayerPropertiesProto(
layer_tree_host_proto->mutable_layer_updates(), inputs_only);
- layer_tree_->LayersThatShouldPushProperties().clear();
std::vector<PictureData> pictures =
engine_picture_cache_->CalculateCacheUpdateAndFlush();
« no previous file with comments | « cc/blimp/layer_factory.h ('k') | cc/layers/layer.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698