Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(153)

Issue 2456063002: Revert "Fix sandbox::PolicyBase leak" (Closed)

Created:
4 years, 1 month ago by pastarmovj
Modified:
4 years, 1 month ago
CC:
chromium-reviews
Target Ref:
refs/pending/branch-heads/2883
Project:
chromium
Visibility:
Public.

Description

Revert "Fix sandbox::PolicyBase leak" This reverts commit b6a4ff86c730756a73d63cc882ef818fb7818a53 because it breaks Chrome when running as a published app on Windows Terminal Services or Citrix XenApp. Original issue's description: > Fix sandbox::PolicyBase leak > > StartSandboxedProcess was missing a Release call, so this was always > leaking. Use scoped_refptr instead to fix that and prevent it from > happening in the future. > TBR=piman@chromium.org > CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win10_chromium_x64_rel_ng > > Committed: https://crrev.com/b6a4ff86c730756a73d63cc882ef818fb7818a53 > Cr-Commit-Position: refs/heads/master@{#417313} BUG=659026 TBR=wfh@chromium.org,cpu@chromium.org,jbauman@chromium.org CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win10_chromium_x64_rel_ng Review-Url: https://codereview.chromium.org/2456573002 Cr-Commit-Position: refs/heads/master@{#427808} (cherry picked from commit 2bfe4d60b683f05eb7fcb96f9a65d8279923f13f) Committed: https://chromium.googlesource.com/chromium/src/+/cfc155174ad04bc706b8b2a7a883583bdc219e9c

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+41 lines, -41 lines) Patch
M content/common/sandbox_init_win.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M content/common/sandbox_win.cc View 6 chunks +7 lines, -8 lines 0 comments Download
M sandbox/win/sandbox_poc/main_ui_window.cc View 2 chunks +2 lines, -1 line 0 comments Download
M sandbox/win/src/broker_services.h View 1 chunk +2 lines, -2 lines 0 comments Download
M sandbox/win/src/broker_services.cc View 7 chunks +9 lines, -11 lines 0 comments Download
M sandbox/win/src/policy_target_test.cc View 10 chunks +12 lines, -12 lines 0 comments Download
M sandbox/win/src/sandbox.h View 3 chunks +2 lines, -3 lines 0 comments Download
M sandbox/win/tests/common/controller.h View 1 chunk +1 line, -1 line 0 comments Download
M sandbox/win/tests/common/controller.cc View 1 chunk +4 lines, -1 line 0 comments Download

Messages

Total messages: 2 (1 generated)
pastarmovj
4 years, 1 month ago (2016-10-27 16:12:12 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
cfc155174ad04bc706b8b2a7a883583bdc219e9c.

Powered by Google App Engine
This is Rietveld 408576698