[ios] Adds the LogoVendor protocol.

[ios] Adds the LogoVendor protocol.

BUG=656617
Committed: https://crrev.com/8f0ace0aa09d3c41551bac36f5846b29bc6b0db7
Cr-Commit-Position: refs/heads/master@{#428336}

[rohitrao (ping after 24h), 2016-10-27 20:43:38]

The CQ bit was checked by rohitrao@chromium.org to run a CQ dry run

[rohitrao (ping after 24h), 2016-10-27 20:44:20]

rohitrao@chromium.org changed reviewers:
+ justincohen@chromium.org

[commit-bot: I haz the power, 2016-10-27 20:44:50]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[rohitrao (ping after 24h), 2016-10-27 20:48:28]

The CQ bit was checked by rohitrao@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-27 20:49:05]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-27 22:11:13]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-27 22:11:13]

Dry run: This issue passed the CQ dry run.

[sdefresne, 2016-10-28 11:27:06]

sdefresne@chromium.org changed reviewers:
+ sdefresne@chromium.org

[sdefresne, 2016-10-28 11:27:07]

lgtm

https://codereview.chromium.org/2456013003/diff/40001/ios/public/provider/chr...
File ios/public/provider/chrome/browser/ui/logo_vendor.h (right):

https://codereview.chromium.org/2456013003/diff/40001/ios/public/provider/chr...
ios/public/provider/chrome/browser/ui/logo_vendor.h:13: @protocol
LogoVendor<LogoAnimationControllerOwnerOwner, NSObject>
Do you need to inherit from NSObject protocol? I think this is only required if
you invoke respondsToSelect: on id<LogoVendor>.

[rohitrao (ping after 24h), 2016-10-28 11:31:58]

https://codereview.chromium.org/2456013003/diff/40001/ios/public/provider/chr...
File ios/public/provider/chrome/browser/ui/logo_vendor.h (right):

https://codereview.chromium.org/2456013003/diff/40001/ios/public/provider/chr...
ios/public/provider/chrome/browser/ui/logo_vendor.h:13: @protocol
LogoVendor<LogoAnimationControllerOwnerOwner, NSObject>
On 2016/10/28 11:27:06, sdefresne wrote:
> Do you need to inherit from NSObject protocol? I think this is only required
if
> you invoke respondsToSelect: on id<LogoVendor>.

I think I can get away without it, but I'd like to keep it because we store and
use objects as id<LogoVendor>, which makes me want them to act like NSObjects.

[rohitrao (ping after 24h), 2016-10-28 11:35:51]

The CQ bit was checked by rohitrao@chromium.org

[commit-bot: I haz the power, 2016-10-28 11:36:12]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-28 11:41:50]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-10-28 11:45:28]

Description was changed from

==========
[ios] Adds the LogoVendor protocol.

BUG=656617
==========

to

==========
[ios] Adds the LogoVendor protocol.

BUG=656617

Committed: https://crrev.com/8f0ace0aa09d3c41551bac36f5846b29bc6b0db7
Cr-Commit-Position: refs/heads/master@{#428336}
==========

[commit-bot: I haz the power, 2016-10-28 11:45:28]

Patchset 3 (id:??) landed as
https://crrev.com/8f0ace0aa09d3c41551bac36f5846b29bc6b0db7
Cr-Commit-Position: refs/heads/master@{#428336}