Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(83)

Issue 2456003002: Allow pagination struts to push objects below the exact top of the next column. (Closed)

Created:
4 years, 1 month ago by mstensho (USE GERRIT)
Modified:
4 years, 1 month ago
Reviewers:
eae
CC:
chromium-reviews, szager+layoutwatch_chromium.org, zoltan1, blink-reviews-layout_chromium.org, pdr+renderingwatchlist_chromium.org, eae+blinkwatch, leviw+renderwatch, jchaffraix+rendering, blink-reviews, mstensho (USE GERRIT)
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Allow pagination struts to push objects below the exact top of the next column. The top margin of a float may push its border box below the top of the next column. Similarly, a repeated table header may do the same to the first row in the next column, to make room for itself above it. The column balancer had assertions to boom at such situations, but it's pretty clear now that it's an unreasonable requirements that sturts take us to the exact top of the next column. Added visual tests that crashed before (in debug). No behavioral changes here, apart from the fact that the tests no longer crash. Committed: https://crrev.com/99812493aac346077f265b7bebd0321d01503d80 Cr-Commit-Position: refs/heads/master@{#428047}

Patch Set 1 #

Messages

Total messages: 12 (7 generated)
mstensho (USE GERRIT)
4 years, 1 month ago (2016-10-27 15:05:05 UTC) #6
eae
OK, LGTM
4 years, 1 month ago (2016-10-27 16:22:10 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2456003002/1
4 years, 1 month ago (2016-10-27 16:22:35 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-10-27 16:27:37 UTC) #10
commit-bot: I haz the power
4 years, 1 month ago (2016-10-27 16:59:09 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/99812493aac346077f265b7bebd0321d01503d80
Cr-Commit-Position: refs/heads/master@{#428047}

Powered by Google App Engine
This is Rietveld 408576698