third_party/WebKit/Source/platform/graphics/OffscreenCanvasFrameDispatcherImpl.h - Issue 2455983005: Refactor AcceleratedStaticBitmapImage

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/graphics/OffscreenCanvasFrameDispatcherImpl.h

Issue 2455983005: Refactor AcceleratedStaticBitmapImage (Closed)

Patch Set: Keep a unique_ptr<WebGraphicsContext3DProvider>, otherwise crashes Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/platform/graphics/MailboxTextureHolder.cpp ('k') | third_party/WebKit/Source/platform/graphics/OffscreenCanvasFrameDispatcherImpl.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/platform/graphics/OffscreenCanvasFrameDispatcherImpl.h

diff --git a/third_party/WebKit/Source/platform/graphics/OffscreenCanvasFrameDispatcherImpl.h b/third_party/WebKit/Source/platform/graphics/OffscreenCanvasFrameDispatcherImpl.h

index 445614bf7277ad802867ac9795a72aef87c589cb..d37162726e803ac8d750350a9756d47e23188ac2 100644

--- a/third_party/WebKit/Source/platform/graphics/OffscreenCanvasFrameDispatcherImpl.h

+++ b/third_party/WebKit/Source/platform/graphics/OffscreenCanvasFrameDispatcherImpl.h

@@ -58,7 +58,7 @@ class PLATFORM_EXPORT OffscreenCanvasFrameDispatcherImpl final

HashMap<unsigned, std::unique_ptr<cc::SharedBitmap>> m_sharedBitmaps;

HashMap<unsigned, GLuint> m_cachedTextureIds;

- bool verifyImageSize(const sk_sp<SkImage>&);

+ bool verifyImageSize(const IntSize);

cc::mojom::blink::MojoCompositorFrameSinkPtr m_sink;

mojo::Binding<cc::mojom::blink::MojoCompositorFrameSinkClient> m_binding;