Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(38)

Side by Side Diff: third_party/WebKit/Source/platform/graphics/gpu/DrawingBuffer.h

Issue 2455983005: Refactor AcceleratedStaticBitmapImage (Closed)
Patch Set: no crash! && address comments Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (c) 2010, Google Inc. All rights reserved. 2 * Copyright (c) 2010, Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 47 matching lines...) Expand 10 before | Expand all | Expand 10 after
58 58
59 namespace WTF { 59 namespace WTF {
60 class ArrayBufferContents; 60 class ArrayBufferContents;
61 } 61 }
62 62
63 namespace blink { 63 namespace blink {
64 class Extensions3DUtil; 64 class Extensions3DUtil;
65 class StaticBitmapImage; 65 class StaticBitmapImage;
66 class WebExternalTextureLayer; 66 class WebExternalTextureLayer;
67 class WebGraphicsContext3DProvider; 67 class WebGraphicsContext3DProvider;
68 class WebGraphicsContext3DProviderWrapper;
68 class WebLayer; 69 class WebLayer;
69 70
70 // Manages a rendering target (framebuffer + attachment) for a canvas. Can 71 // Manages a rendering target (framebuffer + attachment) for a canvas. Can
71 // publish its rendering results to a WebLayer for compositing. 72 // publish its rendering results to a WebLayer for compositing.
72 class PLATFORM_EXPORT DrawingBuffer 73 class PLATFORM_EXPORT DrawingBuffer
73 : public NON_EXPORTED_BASE(cc::TextureLayerClient), 74 : public NON_EXPORTED_BASE(cc::TextureLayerClient),
74 public RefCounted<DrawingBuffer> { 75 public RefCounted<DrawingBuffer> {
75 WTF_MAKE_NONCOPYABLE(DrawingBuffer); 76 WTF_MAKE_NONCOPYABLE(DrawingBuffer);
76 77
77 public: 78 public:
(...skipping 339 matching lines...) Expand 10 before | Expand all | Expand 10 after
417 418
418 // The format to use when creating a multisampled renderbuffer. 419 // The format to use when creating a multisampled renderbuffer.
419 GLenum getMultisampledRenderbufferFormat(); 420 GLenum getMultisampledRenderbufferFormat();
420 421
421 // Weak, reset by beginDestruction. 422 // Weak, reset by beginDestruction.
422 Client* m_client = nullptr; 423 Client* m_client = nullptr;
423 424
424 const PreserveDrawingBuffer m_preserveDrawingBuffer; 425 const PreserveDrawingBuffer m_preserveDrawingBuffer;
425 const WebGLVersion m_webGLVersion; 426 const WebGLVersion m_webGLVersion;
426 427
427 std::unique_ptr<WebGraphicsContext3DProvider> m_contextProvider; 428 std::unique_ptr<WebGraphicsContext3DProviderWrapper> m_contextProvider;
Justin Novosad 2016/11/08 20:41:50 No need for unique_ptr Just: WebGraphicsContext3DP
xidachen 2016/11/08 21:01:54 Done.
428 // Lifetime is tied to the m_contextProvider. 429 // Lifetime is tied to the m_contextProvider.
429 gpu::gles2::GLES2Interface* m_gl; 430 gpu::gles2::GLES2Interface* m_gl;
430 std::unique_ptr<Extensions3DUtil> m_extensionsUtil; 431 std::unique_ptr<Extensions3DUtil> m_extensionsUtil;
431 IntSize m_size = {-1, -1}; 432 IntSize m_size = {-1, -1};
432 const bool m_discardFramebufferSupported; 433 const bool m_discardFramebufferSupported;
433 const bool m_wantAlphaChannel; 434 const bool m_wantAlphaChannel;
434 const bool m_premultipliedAlpha; 435 const bool m_premultipliedAlpha;
435 const bool m_softwareRendering; 436 const bool m_softwareRendering;
436 bool m_hasImplicitStencilBuffer = false; 437 bool m_hasImplicitStencilBuffer = false;
437 bool m_storageTextureSupported = false; 438 bool m_storageTextureSupported = false;
(...skipping 73 matching lines...) Expand 10 before | Expand all | Expand 10 after
511 // RuntimeEnabledFeatures::webGLImageChromiumEnabled() call with 512 // RuntimeEnabledFeatures::webGLImageChromiumEnabled() call with
512 // shouldUseChromiumImage() calls, and set m_chromiumImageUsage to 513 // shouldUseChromiumImage() calls, and set m_chromiumImageUsage to
513 // DisallowChromiumImage in the case of OffscreenCanvas. 514 // DisallowChromiumImage in the case of OffscreenCanvas.
514 ChromiumImageUsage m_chromiumImageUsage; 515 ChromiumImageUsage m_chromiumImageUsage;
515 bool shouldUseChromiumImage(); 516 bool shouldUseChromiumImage();
516 }; 517 };
517 518
518 } // namespace blink 519 } // namespace blink
519 520
520 #endif // DrawingBuffer_h 521 #endif // DrawingBuffer_h
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698