Refactor AcceleratedStaticBitmapImage

third_party/WebKit/Source/platform/graphics/TextureHolder.h

+// Copyright 2016 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef TextureHolder_h
+#define TextureHolder_h
+
+#include "gpu/command_buffer/common/mailbox.h"
+#include "gpu/command_buffer/common/sync_token.h"
+#include "platform/PlatformExport.h"
+#include "platform/geometry/IntSize.h"
+#include "third_party/skia/include/core/SkImage.h"
+#include "third_party/skia/include/core/SkRefCnt.h"
+
+namespace blink {
+
+class WebThread;
+
+class PLATFORM_EXPORT TextureHolder {

[Justin Novosad, 2016/10/28 21:58:41]

There are many methods in this interface that are implemented in only one of the
sub-classes.  You should group them under different headings here. Alos, you
should only make pure virtual the methods that really need to be implemented in
all subclasses, and put default implementations for the rest.  For methods that
should never be called on the wrong type of holder, use a default implementation
with NOTREACHED();

+ public:
+  virtual ~TextureHolder() {}
+
+  virtual bool isSkiaTextureHolder() = 0;
+  virtual unsigned sharedContextId() = 0;
+  virtual gpu::Mailbox getMailbox() = 0;

[Justin Novosad, 2016/10/28 21:58:41]

In blink we don't usually put "get" (or any other verb for that matter) in the
names of methods unless they have to accomplish some kind of task.  A simple
getter like this should just be called "mailbox()".  Same for the getters below.

+  virtual gpu::SyncToken getSyncToken() = 0;
+  virtual IntSize getMailboxSize() = 0;
+  virtual void releaseImageThreadSafe() = 0;
+  virtual sk_sp<SkImage> getSkImage() = 0;
+  virtual WebThread* getImageThread() = 0;
+  virtual IntSize size() const = 0;
+
+  virtual void setSharedContextId(unsigned) = 0;
+  virtual void setImageThread(WebThread*) = 0;
+  virtual void updateSyncToken(gpu::SyncToken) = 0;
+};
+
+}  // namespace blink
+
+#endif  // TextureHolder_h