Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(102)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2455983002: Small cleanups and linter fixes. (Closed)

Created:
4 years, 1 month ago by zra
Modified:
4 years, 1 month ago
Reviewers:
Cutch
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : Small cleanups #

Unified diffs Side-by-side diffs Delta from patch set Stats (+36 lines, -18 lines) Patch
M runtime/bin/file_system_watcher_android.cc View 1 chunk +1 line, -1 line 0 comments Download
M runtime/bin/file_system_watcher_linux.cc View 1 chunk +1 line, -1 line 0 comments Download
M runtime/platform/floating_point_win.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M runtime/vm/code_generator.cc View 1 chunk +1 line, -1 line 0 comments Download
M runtime/vm/cpu_arm.cc View 1 chunk +3 lines, -1 line 0 comments Download
M runtime/vm/cpu_ia32.cc View 1 chunk +1 line, -0 lines 0 comments Download
M runtime/vm/cpu_mips.cc View 1 chunk +2 lines, -1 line 0 comments Download
M runtime/vm/cpu_x64.cc View 1 chunk +1 line, -1 line 0 comments Download
M runtime/vm/instructions_arm.cc View 1 chunk +3 lines, -1 line 0 comments Download
M runtime/vm/instructions_arm64.cc View 1 chunk +3 lines, -1 line 0 comments Download
M runtime/vm/instructions_ia32.cc View 1 chunk +3 lines, -1 line 0 comments Download
M runtime/vm/instructions_mips.cc View 1 chunk +3 lines, -1 line 0 comments Download
M runtime/vm/instructions_x64.cc View 1 chunk +3 lines, -1 line 0 comments Download
M runtime/vm/intermediate_language_arm64.cc View 1 chunk +1 line, -1 line 0 comments Download
M runtime/vm/isolate.cc View 1 chunk +1 line, -1 line 0 comments Download
M runtime/vm/isolate_reload_test.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M runtime/vm/parser.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M runtime/vm/regexp.cc View 1 chunk +1 line, -1 line 0 comments Download
M runtime/vm/unibrow.cc View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
zra
TBR
4 years, 1 month ago (2016-10-27 12:01:55 UTC) #2
zra
Committed patchset #2 (id:20001) manually as e29da6037b4f3b804d97d48e521ac21bada34c87 (presubmit successful).
4 years, 1 month ago (2016-10-27 12:02:25 UTC) #4
Cutch
4 years, 1 month ago (2016-10-27 12:29:59 UTC) #5
Message was sent while issue was closed. 
lgtm

Powered by Google App Engine
This is Rietveld 408576698