[NaCl SDK] Refactor FakeFileSystemInterface.

native_client_sdk/src/tests/nacl_io_test/fake_ppapi/fake_file_system_interface.cc

Index: native_client_sdk/src/tests/nacl_io_test/fake_ppapi/fake_file_system_interface.cc
diff --git a/native_client_sdk/src/tests/nacl_io_test/fake_ppapi/fake_file_system_interface.cc b/native_client_sdk/src/tests/nacl_io_test/fake_ppapi/fake_file_system_interface.cc
new file mode 100644
index 0000000000000000000000000000000000000000..9f6952fb166b6c29db835b7720a21aa644d41e61
--- /dev/null
+++ b/native_client_sdk/src/tests/nacl_io_test/fake_ppapi/fake_file_system_interface.cc
@@ -0,0 +1,64 @@
+// Copyright 2016 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "fake_ppapi/fake_file_system_interface.h"
+
+#include <ppapi/c/pp_completion_callback.h>
+#include <ppapi/c/pp_errors.h>
+
+#include "fake_ppapi/fake_core_interface.h"
+#include "fake_ppapi/fake_pepper_interface_html5_fs.h"
+#include "fake_ppapi/fake_util.h"
+
+namespace {
+
+class FakeInstanceResource : public FakeResource {

[chanpatorikku, 2016/10/27 17:45:50]

FakeInstanceResource used to be used by FakePepperInterfaceHtml5Fs and
FakeFileSystemInterface in fake_pepper_interface_html5_fs.cc.

After refactoring, two exact copies of FakeInstanceResource are in the unnamed
namespaces of fake_pepper_interface_html5_fs.cc and
fake_file_system_interface.cc.

Moving the two exact copies into one copy in, say, fake_util.h results in a
compiler error of FakeInstanceResource being ambiguous because there's another
class FakeInstanceResource with a different definition in
fake_pepper_interface_url_loader.cc:

class FakeInstanceResource : public FakeResource {
 public:
  FakeInstanceResource() : server_template(NULL) {}
  static const char* classname() { return "FakeInstanceResource"; }

  FakeURLLoaderServer* server_template;  // Weak reference.
};

To prevent the compiler error, two exact copies of FakeInstanceResource are in
the unnamed namespaces of FakePepperInterfaceHtml5Fs.cc and
FakeFileSystemInterface.cc.

+ public:
+  FakeInstanceResource() : filesystem_template(NULL) {}
+  static const char* classname() { return "FakeInstanceResource"; }
+
+  FakeHtml5FsFilesystem* filesystem_template;  // Weak reference.
+};
+
+}  // namespace
+
+FakeFileSystemInterface::FakeFileSystemInterface(
+    FakeCoreInterface* core_interface)
+    : core_interface_(core_interface) {}
+
+PP_Bool FakeFileSystemInterface::IsFileSystem(PP_Resource resource) {
+  bool not_found_ok = true;
+  FakeFileSystemResource* file_system_resource =
+      core_interface_->resource_manager()->Get<FakeFileSystemResource>(
+          resource, not_found_ok);
+  return file_system_resource != NULL ? PP_TRUE : PP_FALSE;
+}
+
+PP_Resource FakeFileSystemInterface::Create(PP_Instance instance,
+                                            PP_FileSystemType filesystem_type) {
+  FakeInstanceResource* instance_resource =
+      core_interface_->resource_manager()->Get<FakeInstanceResource>(instance);
+  if (instance_resource == NULL)
+    return PP_ERROR_BADRESOURCE;
+
+  FakeFileSystemResource* file_system_resource = new FakeFileSystemResource;
+  file_system_resource->filesystem = new FakeHtml5FsFilesystem(
+      *instance_resource->filesystem_template, filesystem_type);
+
+  return CREATE_RESOURCE(core_interface_->resource_manager(),
+                         FakeFileSystemResource, file_system_resource);
+}
+
+int32_t FakeFileSystemInterface::Open(PP_Resource file_system,
+                                      int64_t expected_size,
+                                      PP_CompletionCallback callback) {
+  FakeFileSystemResource* file_system_resource =
+      core_interface_->resource_manager()->Get<FakeFileSystemResource>(
+          file_system);
+  if (file_system_resource == NULL)
+    return PP_ERROR_BADRESOURCE;
+
+  file_system_resource->opened = true;
+  return RunCompletionCallback(&callback, PP_OK);
+}