Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(607)

Issue 2455963006: Wires up drag/drop for aura-mus (Closed)

Created:
4 years, 1 month ago by sky
Modified:
4 years, 1 month ago
CC:
chromium-reviews, rjkroege, sadrul, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, tfarina, jam, dcheng, abarth-chromium, Aaron Boodman, darin-cc_chromium.org, yzshen+watch_chromium.org, kalyank, darin (slow to review)
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Wires up drag/drop for aura-mus I combined the drag and drop handling into the same class as the data is shared in the case of drop targeting the same client that initiated the drag. BUG=659155 TEST=covered by tests R=erg@chromium.org, sadrul@chromium.org, tsepez@chromium.org TBR=sadrul@chromium.org Committed: https://crrev.com/d509d739efec6c000cea40aae5e24f8b432cf3d5 Cr-Commit-Position: refs/heads/master@{#428515}

Patch Set 1 #

Patch Set 2 : twweaks #

Unified diffs Side-by-side diffs Delta from patch set Stats (+425 lines, -258 lines) Patch
M ash/drag_drop/drag_drop_controller.cc View 2 chunks +1 line, -1 line 0 comments Download
M content/browser/web_contents/web_contents_view_aura.h View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/web_contents/web_contents_view_aura.cc View 2 chunks +1 line, -1 line 0 comments Download
M services/ui/public/interfaces/window_tree.mojom View 2 chunks +6 lines, -6 lines 0 comments Download
M services/ui/ws/drag_controller.h View 1 chunk +1 line, -1 line 0 comments Download
M services/ui/ws/drag_controller.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/aura/BUILD.gn View 3 chunks +5 lines, -2 lines 0 comments Download
A + ui/aura/client/drag_drop_delegate.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + ui/aura/client/drag_drop_delegate.cc View 1 2 chunks +4 lines, -3 lines 0 comments Download
A ui/aura/mus/drag_drop_controller_host.h View 1 1 chunk +28 lines, -0 lines 0 comments Download
A ui/aura/mus/drag_drop_controller_mus.h View 1 1 chunk +114 lines, -0 lines 0 comments Download
A ui/aura/mus/drag_drop_controller_mus.cc View 1 1 chunk +214 lines, -0 lines 0 comments Download
M ui/aura/mus/window_tree_client.h View 1 7 chunks +7 lines, -26 lines 0 comments Download
M ui/aura/mus/window_tree_client.cc View 12 chunks +25 lines, -124 lines 0 comments Download
M ui/base/window_tracker_template.h View 2 chunks +7 lines, -4 lines 0 comments Download
M ui/views/mus/drop_target_mus.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M ui/views/mus/native_widget_mus.h View 1 chunk +1 line, -1 line 0 comments Download
M ui/views/widget/desktop_aura/desktop_drag_drop_client_aurax11.cc View 2 chunks +1 line, -1 line 0 comments Download
M ui/views/widget/desktop_aura/desktop_drag_drop_client_aurax11_unittest.cc View 2 chunks +1 line, -1 line 0 comments Download
M ui/views/widget/desktop_aura/desktop_drop_target_win.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/views/widget/desktop_aura/desktop_native_widget_aura.h View 2 chunks +1 line, -1 line 0 comments Download
M ui/views/widget/native_widget_aura.h View 2 chunks +1 line, -1 line 0 comments Download
D ui/wm/public/drag_drop_delegate.h View 1 chunk +0 lines, -51 lines 0 comments Download
D ui/wm/public/drag_drop_delegate.cc View 1 chunk +0 lines, -27 lines 0 comments Download

Messages

Total messages: 18 (10 generated)
Tom Sepez
mojom LGTM
4 years, 1 month ago (2016-10-28 21:04:19 UTC) #3
sky
As part of this I moved DragDropClient to aura/client. I'm doing that so ui/aura can ...
4 years, 1 month ago (2016-10-28 21:13:10 UTC) #5
Elliot Glaysher
lgtm
4 years, 1 month ago (2016-10-28 21:22:26 UTC) #8
sky
sadrul I'm TBRing you for the rename.
4 years, 1 month ago (2016-10-28 21:33:54 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2455963006/20001
4 years, 1 month ago (2016-10-28 21:34:28 UTC) #13
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 1 month ago (2016-10-28 22:16:12 UTC) #15
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/d509d739efec6c000cea40aae5e24f8b432cf3d5 Cr-Commit-Position: refs/heads/master@{#428515}
4 years, 1 month ago (2016-10-28 22:17:50 UTC) #17
sadrul
4 years, 1 month ago (2016-10-29 05:55:47 UTC) #18
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698