Subzero, MIPS32: Stacksave/Stackrestore implementation

Subzero, MIPS32: Stacksave/Stackrestore implementation

Implemets Stacksave/Stackrestore; test_stacksave runs successfully
when jal implementation is present, both in forceasm as well as in
elf mode

R=stichnot@chromium.org

Committed: https://gerrit.chromium.org/gerrit/gitweb?p=native_client/pnacl-subzero.git;a=commit;h=f8c9977b34f0c053204f0401b056f4529e23c2a6

[Stefan Maksimovic, 2016-10-27 08:37:17]

Description was changed from

==========
Subzero, MIPS32: Stacksave/Stackrestore implementation

Implemets Stacksave/Stackrestore; test_stacksave runs successfully
when jal implementation is present, both in forceasm as well as in
elf mode
==========

to

==========
Subzero, MIPS32: Stacksave/Stackrestore implementation

Implemets Stacksave/Stackrestore; test_stacksave runs successfully
when jal implementation is present, both in forceasm as well as in
elf mode
==========

[Stefan Maksimovic, 2016-10-27 08:37:17]

makdstefan@gmail.com changed reviewers:
+ jaydeep.patil@imgtec.com, sagar.thakur@imgtec.com, stichnot@chromium.org

[jaydeep.patil, 2016-10-27 09:59:39]

https://codereview.chromium.org/2455933002/diff/1/src/IceTargetLoweringMIPS32.h
File src/IceTargetLoweringMIPS32.h (right):

https://codereview.chromium.org/2455933002/diff/1/src/IceTargetLoweringMIPS32...
src/IceTargetLoweringMIPS32.h:375: // If Instr is multi-dest, then Dest must be
a Variable64On32. We add a
Reflow comment to 80-col

[Jim Stichnoth, 2016-10-27 14:03:38]

https://codereview.chromium.org/2455933002/diff/1/src/IceTargetLoweringMIPS32.h
File src/IceTargetLoweringMIPS32.h (right):

https://codereview.chromium.org/2455933002/diff/1/src/IceTargetLoweringMIPS32...
src/IceTargetLoweringMIPS32.h:375: // If Instr is multi-dest, then Dest must be
a Variable64On32. We add a
On 2016/10/27 09:59:39, jaydeep.patil wrote:
> Reflow comment to 80-col

Actually this needs a "make -f Makefile.standalone format" because the entire
block is indented 2 spaces too many.

[Jim Stichnoth, 2016-10-28 12:36:24]

This looks good, thanks!

Could you also enable the stacksave/stackrestore tests in
nacl-other-intrinsics.ll?

[Stefan Maksimovic, 2016-11-02 08:16:03]

On 2016/10/28 12:36:24, Jim Stichnoth wrote:
> This looks good, thanks!
> 
> Could you also enable the stacksave/stackrestore tests in
> nacl-other-intrinsics.ll?

I've enabled the corresponding tests, please take a look.

[Jim Stichnoth, 2016-11-02 12:58:57]

lgtm

[Jim Stichnoth, 2016-11-02 12:59:09]

Description was changed from

==========
Subzero, MIPS32: Stacksave/Stackrestore implementation

Implemets Stacksave/Stackrestore; test_stacksave runs successfully
when jal implementation is present, both in forceasm as well as in
elf mode
==========

to

==========
Subzero, MIPS32: Stacksave/Stackrestore implementation

Implemets Stacksave/Stackrestore; test_stacksave runs successfully
when jal implementation is present, both in forceasm as well as in
elf mode

R=stichnot@chromium.org

Committed:
https://gerrit.chromium.org/gerrit/gitweb?p=native_client/pnacl-subzero.git;a...
==========

[Jim Stichnoth, 2016-11-02 12:59:10]

Committed patchset #3 (id:40001) manually as
f8c9977b34f0c053204f0401b056f4529e23c2a6 (presubmit successful).