Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(74)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2455883004: Rename _webkit_baseline_path -> _absolute_baseline_path. (Closed)

Created:
4 years, 1 month ago by qyearsley
Modified:
4 years, 1 month ago
Reviewers:
Dirk Pranke
CC:
blink-reviews, chromium-reviews, Dirk Pranke
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Rename _webkit_baseline_path -> _absolute_baseline_path. This is a minor renaming CL to clarify the purpose of this function. BUG=652114 Committed: https://crrev.com/875d3429c3fc94e129a39b28fad4a35a3913ee96 Cr-Commit-Position: refs/heads/master@{#428240}

Patch Set 1 #

Patch Set 2 : Rename _webkit_baseline_path -> _absolute_baseline_path. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -9 lines) Patch
M third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/base.py View 1 3 chunks +6 lines, -6 lines 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/linux_unittest.py View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/win_unittest.py View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/tool/servers/rebaseline_server.py View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 9 (4 generated)
qyearsley
4 years, 1 month ago (2016-10-27 21:45:41 UTC) #3
Dirk Pranke
lgtm
4 years, 1 month ago (2016-10-27 22:17:42 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2455883004/20001
4 years, 1 month ago (2016-10-27 23:33:54 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 1 month ago (2016-10-28 02:10:16 UTC) #7
commit-bot: I haz the power
4 years, 1 month ago (2016-10-28 02:13:58 UTC) #9
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/875d3429c3fc94e129a39b28fad4a35a3913ee96
Cr-Commit-Position: refs/heads/master@{#428240}

Powered by Google App Engine
This is Rietveld 408576698