Add libgtk3ui to gn_all (Reland)

Add libgtk3ui to gn_all (Reland)

BUG=132847
Committed: https://crrev.com/380c0361dde84d52a63f7962d7d726a4069e4f93
Committed: https://crrev.com/98f58ce7cccc266d7fa16f1855d67db173572d31
Cr-Original-Commit-Position: refs/heads/master@{#428090}
Cr-Commit-Position: refs/heads/master@{#429096}

[Tom (Use chromium acct), 2016-10-27 02:20:48]

Description was changed from

==========
Add libgtk3ui to gn_all

BUG=
==========

to

==========
Add libgtk3ui to gn_all

BUG=132847
==========

[Tom (Use chromium acct), 2016-10-27 02:20:48]

thomasanderson@google.com changed reviewers:
+ dpranke@chromium.org

[Tom (Use chromium acct), 2016-10-27 02:21:01]

dpranke@ please review
erg@ FYI

[Tom (Use chromium acct), 2016-10-27 02:23:48]

The CQ bit was checked by thomasanderson@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-10-27 02:24:07]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-27 02:31:51]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-27 02:31:52]

Dry run: Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[Dirk Pranke, 2016-10-27 16:34:37]

lgtm

[Elliot Glaysher, 2016-10-27 16:59:15]

erg@chromium.org changed reviewers:
+ erg@chromium.org

[Elliot Glaysher, 2016-10-27 16:59:16]

lgtm

[Tom (Use chromium acct), 2016-10-27 17:37:14]

The CQ bit was checked by thomasanderson@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-10-27 17:37:46]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-27 18:30:50]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-27 18:30:51]

Dry run: This issue passed the CQ dry run.

[Tom (Use chromium acct), 2016-10-27 18:31:39]

The CQ bit was checked by thomasanderson@google.com

[Tom (Use chromium acct), 2016-10-27 18:31:39]

The patchset sent to the CQ was uploaded after l-g-t-m from
dpranke@chromium.org, erg@chromium.org
Link to the patchset: https://codereview.chromium.org/2455863002/#ps40001
(title: "Don't build libgtk3ui on chromecast")

[commit-bot: I haz the power, 2016-10-27 18:32:58]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-27 18:40:01]

Description was changed from

==========
Add libgtk3ui to gn_all

BUG=132847
==========

to

==========
Add libgtk3ui to gn_all

BUG=132847
==========

[commit-bot: I haz the power, 2016-10-27 18:40:02]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-10-27 19:01:39]

Description was changed from

==========
Add libgtk3ui to gn_all

BUG=132847
==========

to

==========
Add libgtk3ui to gn_all

BUG=132847

Committed: https://crrev.com/380c0361dde84d52a63f7962d7d726a4069e4f93
Cr-Commit-Position: refs/heads/master@{#428090}
==========

[commit-bot: I haz the power, 2016-10-27 19:01:40]

Patchset 3 (id:??) landed as
https://crrev.com/380c0361dde84d52a63f7962d7d726a4069e4f93
Cr-Commit-Position: refs/heads/master@{#428090}

[Tom (Use chromium acct), 2016-10-27 19:56:19]

A revert of this CL (patchset #3 id:40001) has been created in
https://codereview.chromium.org/2456923002/ by thomasanderson@google.com.

The reason for reverting is: Breaks gn gen with the following args.gn:

use_aura = true
use_ozone = true
ozone_auto_platforms = false
ozone_platform = "headless"
ozone_platform_headless = true
metrics_use_blimp = true
use_low_quality_image_interpolation = true
use_external_popup_menu = true
use_alsa = false
use_pulseaudio = false
use_cups = false
use_glib = false
use_udev = false
is_debug = true
use_goma = true
is_component_build = true
.

[Tom (Use chromium acct), 2016-10-27 21:30:03]

Description was changed from

==========
Add libgtk3ui to gn_all

BUG=132847

Committed: https://crrev.com/380c0361dde84d52a63f7962d7d726a4069e4f93
Cr-Commit-Position: refs/heads/master@{#428090}
==========

to

==========
Add libgtk3ui to gn_all (Reland)

BUG=132847

Committed: https://crrev.com/380c0361dde84d52a63f7962d7d726a4069e4f93
Cr-Commit-Position: refs/heads/master@{#428090}
==========

[Tom (Use chromium acct), 2016-10-27 21:35:02]

dpranke@ PTAL at the reland

[Dirk Pranke, 2016-10-27 22:28:15]

lgtm

[Tom (Use chromium acct), 2016-10-27 23:44:33]

The CQ bit was checked by thomasanderson@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-10-27 23:45:00]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-27 23:50:56]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-27 23:50:57]

Dry run: Try jobs failed on following builders:
  chromeos_daisy_chromium_compile_only_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_daisy_...)
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Tom (Use chromium acct), 2016-10-31 18:21:27]

The CQ bit was checked by thomasanderson@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-10-31 18:22:08]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-31 18:59:21]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-31 18:59:23]

Dry run: Try jobs failed on following builders:
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)

[Tom (Use chromium acct), 2016-11-01 18:11:44]

The CQ bit was checked by thomasanderson@google.com

[Tom (Use chromium acct), 2016-11-01 18:11:44]

The patchset sent to the CQ was uploaded after l-g-t-m from erg@chromium.org,
dpranke@chromium.org
Link to the patchset: https://codereview.chromium.org/2455863002/#ps80001
(title: "Revert build/config/ui.gni")

[commit-bot: I haz the power, 2016-11-01 18:12:09]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-01 20:39:48]

Description was changed from

==========
Add libgtk3ui to gn_all (Reland)

BUG=132847

Committed: https://crrev.com/380c0361dde84d52a63f7962d7d726a4069e4f93
Cr-Commit-Position: refs/heads/master@{#428090}
==========

to

==========
Add libgtk3ui to gn_all (Reland)

BUG=132847

Committed: https://crrev.com/380c0361dde84d52a63f7962d7d726a4069e4f93
Cr-Commit-Position: refs/heads/master@{#428090}
==========

[commit-bot: I haz the power, 2016-11-01 20:39:49]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2016-11-01 20:45:36]

Description was changed from

==========
Add libgtk3ui to gn_all (Reland)

BUG=132847

Committed: https://crrev.com/380c0361dde84d52a63f7962d7d726a4069e4f93
Cr-Commit-Position: refs/heads/master@{#428090}
==========

to

==========
Add libgtk3ui to gn_all (Reland)

BUG=132847

Committed: https://crrev.com/380c0361dde84d52a63f7962d7d726a4069e4f93
Committed: https://crrev.com/98f58ce7cccc266d7fa16f1855d67db173572d31
Cr-Original-Commit-Position: refs/heads/master@{#428090}
Cr-Commit-Position: refs/heads/master@{#429096}
==========

[commit-bot: I haz the power, 2016-11-01 20:45:36]

Patchset 5 (id:??) landed as
https://crrev.com/98f58ce7cccc266d7fa16f1855d67db173572d31
Cr-Commit-Position: refs/heads/master@{#429096}