Several tests for AnalysisDriver and an elements.dart tweak.

Several tests for AnalysisDriver and an elements.dart tweak.

I will not land this without review.

R=brianwilkerson@google.com, paulberry@google.com
BUG=

Committed: https://github.com/dart-lang/sdk/commit/0fcf8924d5de7df1929e062779d64f29ef47af9e

[Brian Wilkerson, 2016-10-27 05:06:04]

lgtm

https://codereview.chromium.org/2455843002/diff/1/pkg/analyzer/test/src/dart/...
File pkg/analyzer/test/src/dart/analysis/driver_test.dart (right):

https://codereview.chromium.org/2455843002/diff/1/pkg/analyzer/test/src/dart/...
pkg/analyzer/test/src/dart/analysis/driver_test.dart:48: String _testProject;
Is there any value in these fields being private? The code would be easier to
read without all the underscores.

https://codereview.chromium.org/2455843002/diff/1/pkg/analyzer/test/src/dart/...
pkg/analyzer/test/src/dart/analysis/driver_test.dart:76: driver.priorityFiles =
[_testFile];
These four lines (or sometimes just the first three) get repeated frequently.
Consider a utility method, such as

addFile(String content, {bool priority: false})

https://codereview.chromium.org/2455843002/diff/1/pkg/analyzer/test/src/dart/...
File pkg/analyzer/test/src/dart/analysis/test_all.dart (right):

https://codereview.chromium.org/2455843002/diff/1/pkg/analyzer/test/src/dart/...
pkg/analyzer/test/src/dart/analysis/test_all.dart:9: import 'driver_test.dart'
as drivel;
"drivel" --> "driver"

[scheglov, 2016-10-27 16:24:23]

https://codereview.chromium.org/2455843002/diff/1/pkg/analyzer/test/src/dart/...
File pkg/analyzer/test/src/dart/analysis/driver_test.dart (right):

https://codereview.chromium.org/2455843002/diff/1/pkg/analyzer/test/src/dart/...
pkg/analyzer/test/src/dart/analysis/driver_test.dart:48: String _testProject;
On 2016/10/27 05:06:04, Brian Wilkerson wrote:
> Is there any value in these fields being private? The code would be easier to
> read without all the underscores.

Done.

https://codereview.chromium.org/2455843002/diff/1/pkg/analyzer/test/src/dart/...
pkg/analyzer/test/src/dart/analysis/driver_test.dart:76: driver.priorityFiles =
[_testFile];
On 2016/10/27 05:06:04, Brian Wilkerson wrote:
> These four lines (or sometimes just the first three) get repeated frequently.
> Consider a utility method, such as
> 
> addFile(String content, {bool priority: false})

Done.

https://codereview.chromium.org/2455843002/diff/1/pkg/analyzer/test/src/dart/...
File pkg/analyzer/test/src/dart/analysis/test_all.dart (right):

https://codereview.chromium.org/2455843002/diff/1/pkg/analyzer/test/src/dart/...
pkg/analyzer/test/src/dart/analysis/test_all.dart:9: import 'driver_test.dart'
as drivel;
On 2016/10/27 05:06:04, Brian Wilkerson wrote:
> "drivel" --> "driver"

Done.

[scheglov, 2016-10-27 16:24:36]

Description was changed from

==========
Several tests for AnalysisDriver and an elements.dart tweak.

I will not land this without review.

R=brianwilkerson@google.com, paulberry@google.com
BUG=
==========

to

==========
Several tests for AnalysisDriver and an elements.dart tweak.

I will not land this without review.

R=brianwilkerson@google.com, paulberry@google.com
BUG=

Committed:
https://github.com/dart-lang/sdk/commit/0fcf8924d5de7df1929e062779d64f29ef47af9e
==========

[scheglov, 2016-10-27 16:24:38]

Committed patchset #1 (id:1) manually as
0fcf8924d5de7df1929e062779d64f29ef47af9e (presubmit successful).

[Paul Berry, 2016-10-31 17:53:00]

lgtm