Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(189)

Unified Diff: components/ui_devtools/devtools_server.h

Issue 2455833002: Pass task_runner_ to server and send 404 when incorrect url (Closed)
Patch Set: sadruls comments Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ash/common/wm_shell.cc ('k') | components/ui_devtools/devtools_server.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/ui_devtools/devtools_server.h
diff --git a/components/ui_devtools/devtools_server.h b/components/ui_devtools/devtools_server.h
index a3aa09fcd12750621d578533cd0149909e1df5de..b101ed1c1b8c23a786850484a2de146e36503ce2 100644
--- a/components/ui_devtools/devtools_server.h
+++ b/components/ui_devtools/devtools_server.h
@@ -20,16 +20,19 @@ namespace devtools {
class UiDevToolsServer : public net::HttpServer::Delegate {
public:
- UiDevToolsServer();
~UiDevToolsServer() override;
// Returns an empty unique_ptr if ui devtools flag isn't enabled.
- static std::unique_ptr<UiDevToolsServer> Create();
+ static std::unique_ptr<UiDevToolsServer> Create(
+ scoped_refptr<base::SingleThreadTaskRunner> task_runner);
void AttachClient(std::unique_ptr<UiDevToolsClient> client);
void SendOverWebSocket(int connection_id, const String& message);
private:
+ explicit UiDevToolsServer(
+ scoped_refptr<base::SingleThreadTaskRunner> task_runner);
+
void Start(const std::string& address_string, uint16_t port);
void StartServer(const std::string& address_string, uint16_t port);
@@ -47,10 +50,9 @@ class UiDevToolsServer : public net::HttpServer::Delegate {
ClientsList clients_;
ConnectionsMap connections_;
- // TODO(mhashmi): Inject IO thread task runner instead of creating/owning
- // thread
std::unique_ptr<base::Thread> thread_;
std::unique_ptr<net::HttpServer> server_;
+ scoped_refptr<base::SingleThreadTaskRunner> task_runner_;
DISALLOW_COPY_AND_ASSIGN(UiDevToolsServer);
};
« no previous file with comments | « ash/common/wm_shell.cc ('k') | components/ui_devtools/devtools_server.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698