Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(725)

Unified Diff: components/ui_devtools/devtools_server.h

Issue 2455833002: Pass task_runner_ to server and send 404 when incorrect url (Closed)
Patch Set: Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/ui_devtools/devtools_server.h
diff --git a/components/ui_devtools/devtools_server.h b/components/ui_devtools/devtools_server.h
index a3aa09fcd12750621d578533cd0149909e1df5de..b4ddf8a83e4aba89eb5a2502b02021d03e0716f1 100644
--- a/components/ui_devtools/devtools_server.h
+++ b/components/ui_devtools/devtools_server.h
@@ -20,11 +20,12 @@ namespace devtools {
class UiDevToolsServer : public net::HttpServer::Delegate {
public:
- UiDevToolsServer();
+ UiDevToolsServer(scoped_refptr<base::SingleThreadTaskRunner> task_runner);
sadrul 2016/10/28 02:32:27 explicit
Sarmad Hashmi 2016/10/28 17:02:46 Done.
~UiDevToolsServer() override;
// Returns an empty unique_ptr if ui devtools flag isn't enabled.
- static std::unique_ptr<UiDevToolsServer> Create();
+ static std::unique_ptr<UiDevToolsServer> Create(
+ scoped_refptr<base::SingleThreadTaskRunner> task_runner);
void AttachClient(std::unique_ptr<UiDevToolsClient> client);
void SendOverWebSocket(int connection_id, const String& message);
@@ -47,9 +48,7 @@ class UiDevToolsServer : public net::HttpServer::Delegate {
ClientsList clients_;
ConnectionsMap connections_;
- // TODO(mhashmi): Inject IO thread task runner instead of creating/owning
- // thread
- std::unique_ptr<base::Thread> thread_;
+ scoped_refptr<base::SingleThreadTaskRunner> task_runner_;
std::unique_ptr<net::HttpServer> server_;
DISALLOW_COPY_AND_ASSIGN(UiDevToolsServer);

Powered by Google App Engine
This is Rietveld 408576698