Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(26)

Issue 2455733003: Provide a dedicated getter for the offset to a repeatable THEAD. (Closed)

Created:
4 years, 1 month ago by mstensho (USE GERRIT)
Modified:
4 years, 1 month ago
Reviewers:
rhogan, dgrogan, eae
CC:
chromium-reviews, szager+layoutwatch_chromium.org, zoltan1, blink-reviews-layout_chromium.org, pdr+renderingwatchlist_chromium.org, eae+blinkwatch, leviw+renderwatch, dshwang, jchaffraix+rendering, blink-reviews-paint_chromium.org, blink-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Provide a dedicated getter for the offset to a repeatable THEAD. pageLogicalOffset() is otherwise only used as an optimization during layout, and the way we're optimizing for fragmenting is soon going to change. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Committed: https://crrev.com/5fb3c583c02dcdeaabeb999d96797bb7e307f03e Cr-Commit-Position: refs/heads/master@{#428203}

Patch Set 1 #

Total comments: 2

Patch Set 2 : code review #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -5 lines) Patch
M third_party/WebKit/Source/core/layout/LayoutTable.h View 1 2 chunks +9 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutTable.cpp View 1 1 chunk +5 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/paint/TableSectionPainter.cpp View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 15 (9 generated)
mstensho (USE GERRIT)
4 years, 1 month ago (2016-10-27 15:05:36 UTC) #7
eae
LGTM w/nit https://codereview.chromium.org/2455733003/diff/1/third_party/WebKit/Source/core/layout/LayoutTable.h File third_party/WebKit/Source/core/layout/LayoutTable.h (right): https://codereview.chromium.org/2455733003/diff/1/third_party/WebKit/Source/core/layout/LayoutTable.h#newcode420 third_party/WebKit/Source/core/layout/LayoutTable.h:420: LayoutUnit offsetToFirstRepeatableHeader() const { How about blockOffsetToFirstRepeatableHeader ...
4 years, 1 month ago (2016-10-27 17:05:10 UTC) #8
mstensho (USE GERRIT)
https://codereview.chromium.org/2455733003/diff/1/third_party/WebKit/Source/core/layout/LayoutTable.h File third_party/WebKit/Source/core/layout/LayoutTable.h (right): https://codereview.chromium.org/2455733003/diff/1/third_party/WebKit/Source/core/layout/LayoutTable.h#newcode420 third_party/WebKit/Source/core/layout/LayoutTable.h:420: LayoutUnit offsetToFirstRepeatableHeader() const { On 2016/10/27 17:05:10, eae wrote: ...
4 years, 1 month ago (2016-10-27 20:25:47 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2455733003/20001
4 years, 1 month ago (2016-10-27 20:26:34 UTC) #12
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 1 month ago (2016-10-27 23:23:18 UTC) #13
commit-bot: I haz the power
4 years, 1 month ago (2016-10-27 23:26:38 UTC) #15
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/5fb3c583c02dcdeaabeb999d96797bb7e307f03e
Cr-Commit-Position: refs/heads/master@{#428203}

Powered by Google App Engine
This is Rietveld 408576698