Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(620)

Issue 2455703003: [SPInvalidation] Call LayoutObject::adjustVisualRectForRasterEffects from PaintInvalidator (Closed)

Created:
4 years, 1 month ago by Xianzhu
Modified:
4 years, 1 month ago
Reviewers:
pdr.
CC:
chromium-reviews, shans, dshwang, eae+blinkwatch, fs, kouhei+svg_chromium.org, rwlbuis, krit, szager+layoutwatch_chromium.org, jchaffraix+rendering, blink-reviews-paint_chromium.org, blink-reviews, gyuyoung2, pdr+svgwatchlist_chromium.org, Eric Willigers, rjwright, zoltan1, blink-reviews-layout_chromium.org, darktears, blink-reviews-animation_chromium.org, pdr+renderingwatchlist_chromium.org, leviw+renderwatch, f(malita), Stephen Chennney
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[SPInvalidation] Call LayoutObject::adjustVisualRectForRasterEffects from PaintInvalidator This fixes SVG hairline padding issue of SPInvalidation. Also rebaselined SVG tests we do more accurate pixel snapping for SVGRoot instead of enclosingIntRect() on SVGRoot during rect mapping. BUG=651511 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Committed: https://crrev.com/aa1bdf407523a1ce8429e62f1cf2063aa29f8e76 Cr-Commit-Position: refs/heads/master@{#428546}

Patch Set 1 #

Patch Set 2 : - #

Patch Set 3 : - #

Patch Set 4 : - #

Patch Set 5 : - #

Unified diffs Side-by-side diffs Delta from patch set Stats (+289 lines, -300 lines) Patch
M third_party/WebKit/LayoutTests/FlagExpectations/enable-blink-features=SlimmingPaintInvalidation View 1 2 3 3 chunks +6 lines, -9 lines 0 comments Download
A + third_party/WebKit/LayoutTests/flag-specific/enable-blink-features=SlimmingPaintInvalidation/paint/invalidation/svg/absolute-sized-document-no-scrollbars-expected.txt View 1 chunk +6 lines, -1 line 0 comments Download
A + third_party/WebKit/LayoutTests/flag-specific/enable-blink-features=SlimmingPaintInvalidation/paint/invalidation/svg/animated-path-inside-transformed-html-expected.txt View 1 chunk +6 lines, -6 lines 0 comments Download
A + third_party/WebKit/LayoutTests/flag-specific/enable-blink-features=SlimmingPaintInvalidation/paint/invalidation/svg/deep-dynamic-updates-expected.txt View 1 chunk +2 lines, -2 lines 0 comments Download
A + third_party/WebKit/LayoutTests/flag-specific/enable-blink-features=SlimmingPaintInvalidation/paint/invalidation/svg/js-late-gradient-and-object-creation-expected.txt View 1 chunk +2 lines, -2 lines 0 comments Download
A + third_party/WebKit/LayoutTests/flag-specific/enable-blink-features=SlimmingPaintInvalidation/paint/invalidation/svg/js-late-marker-and-object-creation-expected.txt View 1 chunk +2 lines, -2 lines 0 comments Download
A + third_party/WebKit/LayoutTests/flag-specific/enable-blink-features=SlimmingPaintInvalidation/paint/invalidation/svg/js-late-marker-creation-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
A + third_party/WebKit/LayoutTests/flag-specific/enable-blink-features=SlimmingPaintInvalidation/paint/invalidation/svg/js-late-pattern-and-object-creation-expected.txt View 1 chunk +2 lines, -2 lines 0 comments Download
A + third_party/WebKit/LayoutTests/flag-specific/enable-blink-features=SlimmingPaintInvalidation/paint/invalidation/svg/js-update-bounce-expected.txt View 2 chunks +6 lines, -6 lines 0 comments Download
A + third_party/WebKit/LayoutTests/flag-specific/enable-blink-features=SlimmingPaintInvalidation/paint/invalidation/svg/js-update-container-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
A + third_party/WebKit/LayoutTests/flag-specific/enable-blink-features=SlimmingPaintInvalidation/paint/invalidation/svg/js-update-polygon-changes-expected.txt View 1 chunk +2 lines, -2 lines 0 comments Download
A + third_party/WebKit/LayoutTests/flag-specific/enable-blink-features=SlimmingPaintInvalidation/paint/invalidation/svg/js-update-polygon-removal-expected.txt View 1 chunk +2 lines, -2 lines 0 comments Download
A + third_party/WebKit/LayoutTests/flag-specific/enable-blink-features=SlimmingPaintInvalidation/paint/invalidation/svg/js-update-transform-addition-expected.txt View 1 chunk +1 line, -6 lines 0 comments Download
A + third_party/WebKit/LayoutTests/flag-specific/enable-blink-features=SlimmingPaintInvalidation/paint/invalidation/svg/js-update-transform-changes-expected.txt View 1 chunk +1 line, -6 lines 0 comments Download
A + third_party/WebKit/LayoutTests/flag-specific/enable-blink-features=SlimmingPaintInvalidation/paint/invalidation/svg/paintorder-filtered-expected.txt View 2 chunks +2 lines, -2 lines 0 comments Download
A + third_party/WebKit/LayoutTests/flag-specific/enable-blink-features=SlimmingPaintInvalidation/paint/invalidation/svg/relative-sized-content-with-resources-expected.txt View 2 chunks +2 lines, -2 lines 0 comments Download
A + third_party/WebKit/LayoutTests/flag-specific/enable-blink-features=SlimmingPaintInvalidation/paint/invalidation/svg/repaint-paintorder-expected.txt View 2 chunks +8 lines, -8 lines 0 comments Download
A + third_party/WebKit/LayoutTests/flag-specific/enable-blink-features=SlimmingPaintInvalidation/paint/invalidation/svg/stroke-opacity-update-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
A + third_party/WebKit/LayoutTests/flag-specific/enable-blink-features=SlimmingPaintInvalidation/paint/invalidation/svg/tabgroup-expected.txt View 11 chunks +64 lines, -64 lines 0 comments Download
A + third_party/WebKit/LayoutTests/flag-specific/enable-blink-features=SlimmingPaintInvalidation/paint/invalidation/svg/use-detach-expected.txt View 1 chunk +18 lines, -18 lines 0 comments Download
A + third_party/WebKit/LayoutTests/flag-specific/enable-blink-features=SlimmingPaintInvalidation/paint/invalidation/svg/window-expected.txt View 14 chunks +137 lines, -137 lines 0 comments Download
M third_party/WebKit/LayoutTests/paint/invalidation/svg/js-update-transform-addition-expected.txt View 3 4 1 chunk +0 lines, -5 lines 0 comments Download
M third_party/WebKit/LayoutTests/paint/invalidation/svg/js-update-transform-changes-expected.txt View 3 4 1 chunk +0 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutObject.h View 1 2 3 4 2 chunks +7 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/core/layout/svg/LayoutSVGShape.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/layout/svg/LayoutSVGShape.cpp View 1 chunk +6 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/paint/PaintInvalidator.cpp View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 29 (20 generated)
Xianzhu
4 years, 1 month ago (2016-10-26 21:39:18 UTC) #13
pdr.
On 2016/10/26 at 21:39:18, wangxianzhu wrote: > LGTM, woohoo!
4 years, 1 month ago (2016-10-27 02:17:36 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2455703003/60001
4 years, 1 month ago (2016-10-27 16:39:39 UTC) #16
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/320489)
4 years, 1 month ago (2016-10-27 18:05:56 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2455703003/80001
4 years, 1 month ago (2016-10-28 19:18:09 UTC) #21
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/326931)
4 years, 1 month ago (2016-10-28 20:46:07 UTC) #23
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2455703003/80001
4 years, 1 month ago (2016-10-28 21:25:56 UTC) #25
commit-bot: I haz the power
Committed patchset #5 (id:80001)
4 years, 1 month ago (2016-10-28 23:34:35 UTC) #27
commit-bot: I haz the power
4 years, 1 month ago (2016-10-28 23:37:58 UTC) #29
Message was sent while issue was closed.
Patchset 5 (id:??) landed as
https://crrev.com/aa1bdf407523a1ce8429e62f1cf2063aa29f8e76
Cr-Commit-Position: refs/heads/master@{#428546}

Powered by Google App Engine
This is Rietveld 408576698