Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(18)

Issue 24557002: dbus: Rewrite ObjectProxy::ConnectToSignal with PostTaskAndReplyWithResult (Closed)

Created:
7 years, 2 months ago by hashimoto
Modified:
7 years, 2 months ago
Reviewers:
satorux1
CC:
chromium-reviews
Visibility:
Public.

Description

dbus: Rewrite ObjectProxy::ConnectToSignal with PostTaskAndReplyWithResult BUG=None TEST=dbus_unittests R=satorux@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=225362

Patch Set 1 #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+51 lines, -76 lines) Patch
M dbus/object_proxy.h View 1 chunk +3 lines, -11 lines 0 comments Download
M dbus/object_proxy.cc View 3 chunks +48 lines, -65 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
hashimoto
This change depends on "Replace PostTaskTo*Thread methods with Get*TaskRunner" (https://codereview.chromium.org/24554002/)
7 years, 2 months ago (2013-09-25 10:48:14 UTC) #1
satorux1
LGTM! Much simpler!
7 years, 2 months ago (2013-09-26 01:21:30 UTC) #2
hashimoto
7 years, 2 months ago (2013-09-26 06:40:41 UTC) #3
Message was sent while issue was closed.
Committed patchset #2 manually as r225362 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698