Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(613)

Issue 2455693004: Media: fail properly on 404 after redirect (Closed)

Created:
4 years, 1 month ago by hubbe
Modified:
4 years, 1 month ago
Reviewers:
DaleCurtis
CC:
chromium-reviews, feature-media-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Media: fail properly on 404 after redirect Because the readers were still hooked up to the pre-redirect URL, calling Fail() did not propagate properly. Also fix some debug statements I needed to find the problem. BUG=652737 Committed: https://crrev.com/e547f4e0b3e0796fb44b508d20ea313f3cb735f1 Cr-Commit-Position: refs/heads/master@{#428251}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -5 lines) Patch
M media/blink/multibuffer_data_source_unittest.cc View 1 chunk +13 lines, -0 lines 0 comments Download
M media/blink/resource_multibuffer_data_provider.cc View 7 chunks +16 lines, -5 lines 0 comments Download

Messages

Total messages: 13 (9 generated)
DaleCurtis
lgtm
4 years, 1 month ago (2016-10-27 22:23:03 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2455693004/1
4 years, 1 month ago (2016-10-28 00:09:24 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-10-28 02:21:37 UTC) #11
commit-bot: I haz the power
4 years, 1 month ago (2016-10-28 02:24:32 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/e547f4e0b3e0796fb44b508d20ea313f3cb735f1
Cr-Commit-Position: refs/heads/master@{#428251}

Powered by Google App Engine
This is Rietveld 408576698