components/sync/model/model_type_service.h - Issue 2455693002: [Sync] On disabling sync, device info records are removed.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/sync/model/model_type_service.h

Issue 2455693002: [Sync] On disabling sync, device info records are removed. (Closed)

Patch Set: Adjusting TODOs. Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: components/sync/model/model_type_service.h

diff --git a/components/sync/model/model_type_service.h b/components/sync/model/model_type_service.h

index 9e63c8f571e47082d00f1156d9c98369074135a6..3d39d5b16687db84b56f7ea3e3bf599baf34813c 100644

--- a/components/sync/model/model_type_service.h

+++ b/components/sync/model/model_type_service.h

@@ -111,8 +111,7 @@ class ModelTypeService : public base::SupportsWeakPtr<ModelTypeService> {

// Indicates that we no longer want to do any sync-related things for this

// data type. Severs all ties to the sync thread, deletes all local sync

// metadata, and then destroys the change processor.

- // TODO(crbug.com/584365): This needs to be called from DataTypeController.

- void DisableSync();

+ virtual void DisableSync();

ModelTypeChangeProcessor* change_processor() const;