Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(257)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2455673003: DevTools: Install local node.js for Mac (Closed)

Created:
4 years, 1 month ago by chenwilliam
Modified:
4 years, 1 month ago
Reviewers:
dgozman
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, pfeldman, kozyatinskiy+blink_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

DevTools: Install local node.js for Mac BUG=642046 Committed: https://crrev.com/f5cf2be3e760df7129ad164948c5ebd6772b70c7 Cr-Commit-Position: refs/heads/master@{#428202}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M third_party/WebKit/Source/devtools/scripts/install_node_deps.py View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
chenwilliam
PTAL. I enabled installing local node.js for Mac and it works on my personal Mac ...
4 years, 1 month ago (2016-10-27 00:54:42 UTC) #3
dgozman
lgtm
4 years, 1 month ago (2016-10-27 20:16:12 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2455673003/1
4 years, 1 month ago (2016-10-27 20:19:40 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-10-27 23:22:09 UTC) #8
commit-bot: I haz the power
4 years, 1 month ago (2016-10-27 23:26:36 UTC) #10
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/f5cf2be3e760df7129ad164948c5ebd6772b70c7
Cr-Commit-Position: refs/heads/master@{#428202}

Powered by Google App Engine
This is Rietveld 408576698