Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(458)

Unified Diff: chrome/browser/pdf/pdf_extension_test.cc

Issue 2455663004: Add test to ensure that URLs that redirect inside the PDF plugin fail to load (Closed)
Patch Set: Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/pdf/pdf_extension_test.cc
diff --git a/chrome/browser/pdf/pdf_extension_test.cc b/chrome/browser/pdf/pdf_extension_test.cc
index 74f8a17e9ee227943c303474307bc91e4148e893..fd907fbbb2e6e9004cf9d88d96165810073a3c76 100644
--- a/chrome/browser/pdf/pdf_extension_test.cc
+++ b/chrome/browser/pdf/pdf_extension_test.cc
@@ -909,3 +909,10 @@ IN_PROC_BROWSER_TEST_F(PDFExtensionTest, LinkShiftLeftClick) {
const GURL& url = active_web_contents->GetURL();
ASSERT_EQ(std::string("http://www.example.com/"), url.spec());
}
+
+// Test that if the plugin tries to load a URL that redirects that it will fail
+// to load. This is to avoid the source origin of the document changing during
+// the redirect, which can have security implications. crbug.com/653749
+IN_PROC_BROWSER_TEST_F(PDFExtensionTest, RedirectsFailInPlugin) {
+ RunTestsInFile("redirects_fail_test.js", "test.pdf");
+}
« no previous file with comments | « no previous file | chrome/test/data/pdf/redirects_fail_test.js » ('j') | chrome/test/data/pdf/redirects_fail_test.js » ('J')

Powered by Google App Engine
This is Rietveld 408576698