pdf/pdfium/pdfium_engine.cc - Issue 2455663004: Add test to ensure that URLs that redirect inside the PDF plugin fail to load

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pdf/pdfium/pdfium_engine.cc

Issue 2455663004: Add test to ensure that URLs that redirect inside the PDF plugin fail to load (Closed)

Patch Set: Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: pdf/pdfium/pdfium_engine.cc

diff --git a/pdf/pdfium/pdfium_engine.cc b/pdf/pdfium/pdfium_engine.cc

index 475d56933053765ad2f460b8ca1d7a89df84a095..5ee296a1ebd64f757f5219788e1c18f1d0cc33b8 100644

--- a/pdf/pdfium/pdfium_engine.cc

+++ b/pdf/pdfium/pdfium_engine.cc

@@ -1106,7 +1106,7 @@ void PDFiumEngine::OnDocumentComplete() {

}

void PDFiumEngine::OnDocumentCanceled() {

- OnDocumentComplete();

+ client_->DocumentLoadFailed();

snake 2016/11/09 14:27:28 May be more better?: if (visible_pages_.empty()) {

raymes 2016/11/14 00:36:09 Done.

}

void PDFiumEngine::CancelBrowserDownload() {

« no previous file with comments | « pdf/out_of_process_instance.cc ('k') | no next file » | no next file with comments »