Add test to ensure that URLs that redirect inside the PDF plugin fail to load

pdf/out_of_process_instance.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "pdf/out_of_process_instance.h"
 
 #include <stddef.h>
 #include <stdint.h>
 
 #include <algorithm>  // for min/max()
@@ skipping 828 matching lines @@
         ready->push_back(
             PaintManager::ReadyRect(intersection, image_data_, false));
       }
     }
   }
 
   engine_->PostPaint();
 }
 
 void OutOfProcessInstance::DidOpen(int32_t result) {
-  if (result == PP_OK) {
-    if (!engine_->HandleDocumentLoad(embed_loader_)) {
-      document_load_state_ = LOAD_STATE_LOADING;
-      DocumentLoadFailed();
-    }
-  } else if (result != PP_ERROR_ABORTED) {  // Can happen in tests.
-    NOTREACHED();
+  if (result != PP_OK || !engine_->HandleDocumentLoad(embed_loader_)) {
+    document_load_state_ = LOAD_STATE_LOADING;

[Lei Zhang, 2016/11/08 01:28:10]

Side note: I wonder if this is actually needed to satisfy the DCHECK at the top
of DocumentLoadFailed(). i.e. Is |document_load_state_| already in the loading
state?

[raymes, 2016/11/08 06:00:01]

Done.

[Lei Zhang, 2016/11/08 07:19:31]

Wasn't expecting this change, but if it works, then ok.

     DocumentLoadFailed();
   }
 }
 
 void OutOfProcessInstance::DidOpenPreview(int32_t result) {
   if (result == PP_OK) {
     preview_client_.reset(new PreviewModeClient(this));
     preview_engine_.reset(PDFEngine::Create(preview_client_.get()));
     preview_engine_->HandleDocumentLoad(embed_preview_loader_);
   } else {
@@ skipping 577 matching lines @@
                   &OutOfProcessInstance::DidOpenPreview);
 }
 
 void OutOfProcessInstance::LoadUrlInternal(
     const std::string& url,
     pp::URLLoader* loader,
     void (OutOfProcessInstance::* method)(int32_t)) {
   pp::URLRequestInfo request(this);
   request.SetURL(url);
   request.SetMethod("GET");
+  request.SetFollowRedirects(false);
 
   *loader = CreateURLLoaderInternal();
   pp::CompletionCallback callback = loader_factory_.NewCallback(method);
   int rv = loader->Open(request, callback);
   if (rv != PP_OK_COMPLETIONPENDING)
     callback.Run(rv);
 }
 
 pp::URLLoader OutOfProcessInstance::CreateURLLoaderInternal() {
   pp::URLLoader loader(this);
@@ skipping 84 matching lines @@
     const pp::FloatPoint& scroll_offset) {
   float max_x = document_size_.width() * zoom_ - plugin_dip_size_.width();
   float x = std::max(std::min(scroll_offset.x(), max_x), 0.0f);
   float min_y = -top_toolbar_height_;
   float max_y = document_size_.height() * zoom_ - plugin_dip_size_.height();
   float y = std::max(std::min(scroll_offset.y(), max_y), min_y);
   return pp::FloatPoint(x, y);
 }
 
 }  // namespace chrome_pdf