Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1956)

Unified Diff: chrome/browser/prerender/prerender_browsertest.cc

Issue 2455653005: Revert "Revert of [NoStatePrefetch] Kill renderer after preload scanning (patchset #12 id:240001 of… (Closed)
Patch Set: rebased Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/prerender/prerender_final_status.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/prerender/prerender_browsertest.cc
diff --git a/chrome/browser/prerender/prerender_browsertest.cc b/chrome/browser/prerender/prerender_browsertest.cc
index e51954071cd4d2354ab157ff0fcfb340d2d1f9ac..de67ade1c5e41b312dc4d796be7a55534d7b4463 100644
--- a/chrome/browser/prerender/prerender_browsertest.cc
+++ b/chrome/browser/prerender/prerender_browsertest.cc
@@ -604,6 +604,36 @@ class PrerenderBrowserTest : public test_utils::PrerenderInProcessBrowserTest {
~PrerenderBrowserTest() override {}
+ std::unique_ptr<TestPrerender> PrerenderTestURL(
+ const std::string& html_file,
+ FinalStatus expected_final_status,
+ int expected_number_of_loads) {
+ GURL url = src_server()->GetURL(MakeAbsolute(html_file));
+ return PrerenderTestURL(url, expected_final_status,
+ expected_number_of_loads);
+ }
+
+ std::unique_ptr<TestPrerender> PrerenderTestURL(
+ const GURL& url,
+ FinalStatus expected_final_status,
+ int expected_number_of_loads) {
+ std::vector<FinalStatus> expected_final_status_queue(1,
+ expected_final_status);
+ auto prerenders = PrerenderTestURLImpl(url, expected_final_status_queue,
+ expected_number_of_loads);
+ CHECK_EQ(1u, prerenders.size());
+ return std::move(prerenders[0]);
+ }
+
+ std::vector<std::unique_ptr<TestPrerender>> PrerenderTestURL(
+ const std::string& html_file,
+ const std::vector<FinalStatus>& expected_final_status_queue,
+ int expected_number_of_loads) {
+ GURL url = src_server()->GetURL(MakeAbsolute(html_file));
+ return PrerenderTestURLImpl(url, expected_final_status_queue,
+ expected_number_of_loads);
+ }
+
void SetUpCommandLine(base::CommandLine* command_line) override {
PrerenderInProcessBrowserTest::SetUpCommandLine(command_line);
command_line->AppendSwitchASCII(switches::kPrerenderMode,
@@ -914,27 +944,19 @@ class PrerenderBrowserTest : public test_utils::PrerenderInProcessBrowserTest {
std::vector<std::unique_ptr<TestPrerender>> PrerenderTestURLImpl(
const GURL& prerender_url,
const std::vector<FinalStatus>& expected_final_status_queue,
- int expected_number_of_loads) override {
+ int expected_number_of_loads) {
dest_url_ = prerender_url;
- base::StringPairs replacement_text;
- replacement_text.push_back(
- make_pair("REPLACE_WITH_PRERENDER_URL", prerender_url.spec()));
- std::string replacement_path;
- net::test_server::GetFilePathWithReplacements(
- loader_path_, replacement_text, &replacement_path);
-
- GURL loader_url =
- src_server()->GetURL(replacement_path + "&" + loader_query_);
-
+ GURL loader_url = ServeLoaderURL(loader_path_, "REPLACE_WITH_PRERENDER_URL",
+ prerender_url, "&" + loader_query_);
GURL::Replacements loader_replacements;
if (!loader_host_override_.empty())
loader_replacements.SetHostStr(loader_host_override_);
loader_url = loader_url.ReplaceComponents(loader_replacements);
std::vector<std::unique_ptr<TestPrerender>> prerenders =
- NavigateWithPrerenders(loader_url, expected_final_status_queue,
- expected_number_of_loads);
+ NavigateWithPrerenders(loader_url, expected_final_status_queue);
+ prerenders[0]->WaitForLoads(expected_number_of_loads);
FinalStatus expected_final_status = expected_final_status_queue.front();
if (ShouldAbortPrerenderBeforeSwap(expected_final_status)) {
« no previous file with comments | « no previous file | chrome/browser/prerender/prerender_final_status.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698