Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(394)

Issue 2455653003: Add mapping for Xbox One S controller on Linux and Android (Closed)

Created:
4 years, 1 month ago by cgutman
Modified:
4 years, 1 month ago
CC:
agrieve+watch_chromium.org, chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add mapping for Xbox One S controller on Linux and Android This brings the functionality of the One S controller over Bluetooth on Android and Linux up to parity with Windows and Mac mappings. BUG=659901 TEST=http://html5gamepad.com/ Committed: https://crrev.com/213cc34910a02a969800bc9e8de9d0becdeb4852 Cr-Commit-Position: refs/heads/master@{#428242}

Patch Set 1 #

Total comments: 1

Patch Set 2 : Added trigger idle test and fixed a bug it uncovered #

Unified diffs Side-by-side diffs Delta from patch set Stats (+190 lines, -3 lines) Patch
M device/gamepad/android/java/src/org/chromium/device/gamepad/GamepadMappings.java View 1 3 chunks +72 lines, -0 lines 0 comments Download
M device/gamepad/android/junit/src/org/chromium/device/gamepad/GamepadMappingsTest.java View 1 4 chunks +96 lines, -3 lines 0 comments Download
M device/gamepad/gamepad_standard_mappings_linux.cc View 2 chunks +22 lines, -0 lines 0 comments Download

Messages

Total messages: 17 (8 generated)
cgutman
Finally got around to making these mappings for Linux and Android. The Xbox One S ...
4 years, 1 month ago (2016-10-27 06:19:16 UTC) #3
aelias_OOO_until_Jul13
lgtm https://codereview.chromium.org/2455653003/diff/1/device/gamepad/android/junit/src/org/chromium/device/gamepad/GamepadMappingsTest.java File device/gamepad/android/junit/src/org/chromium/device/gamepad/GamepadMappingsTest.java (right): https://codereview.chromium.org/2455653003/diff/1/device/gamepad/android/junit/src/org/chromium/device/gamepad/GamepadMappingsTest.java#newcode149 device/gamepad/android/junit/src/org/chromium/device/gamepad/GamepadMappingsTest.java:149: public void testXboxWirelessGamepadMappings() throws Exception { Could you ...
4 years, 1 month ago (2016-10-27 06:28:34 UTC) #4
cgutman
On 2016/10/27 06:28:34, aelias wrote: > lgtm > > https://codereview.chromium.org/2455653003/diff/1/device/gamepad/android/junit/src/org/chromium/device/gamepad/GamepadMappingsTest.java > File > device/gamepad/android/junit/src/org/chromium/device/gamepad/GamepadMappingsTest.java > ...
4 years, 1 month ago (2016-10-27 06:58:59 UTC) #5
bajones
LGTM, thanks!
4 years, 1 month ago (2016-10-27 22:27:22 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2455653003/20001
4 years, 1 month ago (2016-10-27 22:50:53 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_swarming_rel/builds/57394)
4 years, 1 month ago (2016-10-28 00:05:35 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2455653003/20001
4 years, 1 month ago (2016-10-28 00:12:24 UTC) #13
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 1 month ago (2016-10-28 02:12:13 UTC) #15
commit-bot: I haz the power
4 years, 1 month ago (2016-10-28 02:14:01 UTC) #17
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/213cc34910a02a969800bc9e8de9d0becdeb4852
Cr-Commit-Position: refs/heads/master@{#428242}

Powered by Google App Engine
This is Rietveld 408576698