Add mapping for Xbox One S controller on Linux and Android

Add mapping for Xbox One S controller on Linux and Android

This brings the functionality of the One S controller over Bluetooth
on Android and Linux up to parity with Windows and Mac mappings.

BUG=659901
TEST=http://html5gamepad.com/

Committed: https://crrev.com/213cc34910a02a969800bc9e8de9d0becdeb4852
Cr-Commit-Position: refs/heads/master@{#428242}

[cgutman, 2016-10-27 06:14:19]

Description was changed from

==========
Add mapping for Xbox One S controller on Linux and Android

This brings the functionality of the One S controller over Bluetooth
on Android and Linux up to parity with Windows and Mac mappings.

BUG=659901
TEST=http://html5gamepad.com/
==========

to

==========
Add mapping for Xbox One S controller on Linux and Android

This brings the functionality of the One S controller over Bluetooth
on Android and Linux up to parity with Windows and Mac mappings.

BUG=659901
TEST=http://html5gamepad.com/
==========

[cgutman, 2016-10-27 06:14:19]

aicommander@gmail.com changed reviewers:
+ aelias@chromium.org, bajones@chromium.org, scottmg@chromium.org

[cgutman, 2016-10-27 06:19:16]

Finally got around to making these mappings for Linux and
Android. The Xbox One S controller is a bit of a pain to
connect to a normal Linux distro (tried Ubuntu 16.04 and
Fedora 24). It needs:

echo 1 > /sys/module/bluetooth/parameters/disable_ertm

to connect at all. However, it has no problem connecting
to any of my Android devices.

[aelias_OOO_until_Jul13, 2016-10-27 06:28:34]

lgtm

https://codereview.chromium.org/2455653003/diff/1/device/gamepad/android/juni...
File
device/gamepad/android/junit/src/org/chromium/device/gamepad/GamepadMappingsTest.java
(right):

https://codereview.chromium.org/2455653003/diff/1/device/gamepad/android/juni...
device/gamepad/android/junit/src/org/chromium/device/gamepad/GamepadMappingsTest.java:149:
public void testXboxWirelessGamepadMappings() throws Exception {
Could you add a test case for the shoulder 0/-1 logic?

[cgutman, 2016-10-27 06:58:59]

On 2016/10/27 06:28:34, aelias wrote:
> lgtm
> 
>
https://codereview.chromium.org/2455653003/diff/1/device/gamepad/android/juni...
> File
>
device/gamepad/android/junit/src/org/chromium/device/gamepad/GamepadMappingsTest.java
> (right):
> 
>
https://codereview.chromium.org/2455653003/diff/1/device/gamepad/android/juni...
>
device/gamepad/android/junit/src/org/chromium/device/gamepad/GamepadMappingsTest.java:149:
> public void testXboxWirelessGamepadMappings() throws Exception {
> Could you add a test case for the shoulder 0/-1 logic?

Done. Also fixed a bug the test uncovered.

[bajones, 2016-10-27 22:27:22]

LGTM, thanks!

[cgutman, 2016-10-27 22:50:03]

The CQ bit was checked by aicommander@gmail.com

[cgutman, 2016-10-27 22:50:04]

The patchset sent to the CQ was uploaded after l-g-t-m from aelias@chromium.org
Link to the patchset: https://codereview.chromium.org/2455653003/#ps20001
(title: "Added trigger idle test and fixed a bug it uncovered")

[commit-bot: I haz the power, 2016-10-27 22:50:53]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-28 00:05:34]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-28 00:05:35]

Try jobs failed on following builders:
  android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_...)

[aelias_OOO_until_Jul13, 2016-10-28 00:11:50]

The CQ bit was checked by aelias@chromium.org

[commit-bot: I haz the power, 2016-10-28 00:12:24]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-28 02:12:12]

Description was changed from

==========
Add mapping for Xbox One S controller on Linux and Android

This brings the functionality of the One S controller over Bluetooth
on Android and Linux up to parity with Windows and Mac mappings.

BUG=659901
TEST=http://html5gamepad.com/
==========

to

==========
Add mapping for Xbox One S controller on Linux and Android

This brings the functionality of the One S controller over Bluetooth
on Android and Linux up to parity with Windows and Mac mappings.

BUG=659901
TEST=http://html5gamepad.com/
==========

[commit-bot: I haz the power, 2016-10-28 02:12:13]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-10-28 02:14:00]

Description was changed from

==========
Add mapping for Xbox One S controller on Linux and Android

This brings the functionality of the One S controller over Bluetooth
on Android and Linux up to parity with Windows and Mac mappings.

BUG=659901
TEST=http://html5gamepad.com/
==========

to

==========
Add mapping for Xbox One S controller on Linux and Android

This brings the functionality of the One S controller over Bluetooth
on Android and Linux up to parity with Windows and Mac mappings.

BUG=659901
TEST=http://html5gamepad.com/

Committed: https://crrev.com/213cc34910a02a969800bc9e8de9d0becdeb4852
Cr-Commit-Position: refs/heads/master@{#428242}
==========

[commit-bot: I haz the power, 2016-10-28 02:14:01]

Patchset 2 (id:??) landed as
https://crrev.com/213cc34910a02a969800bc9e8de9d0becdeb4852
Cr-Commit-Position: refs/heads/master@{#428242}