Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(534)

Unified Diff: ui/android/java/src/org/chromium/ui/display/DisplayAndroidManager.java

Issue 2455653002: Make clear that WindowAndroid::getDisplay must be used when supporting multi-display. (Closed)
Patch Set: Revert change that snuck in from other branch Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ui/android/java/src/org/chromium/ui/display/DisplayAndroid.java ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ui/android/java/src/org/chromium/ui/display/DisplayAndroidManager.java
diff --git a/ui/android/java/src/org/chromium/ui/display/DisplayAndroidManager.java b/ui/android/java/src/org/chromium/ui/display/DisplayAndroidManager.java
index dd86c1e152987fb92f81c3f873db1459a87e09d8..11911f02092b1efd12fe7596774c8f784217cee2 100644
--- a/ui/android/java/src/org/chromium/ui/display/DisplayAndroidManager.java
+++ b/ui/android/java/src/org/chromium/ui/display/DisplayAndroidManager.java
@@ -113,7 +113,8 @@ import org.chromium.ui.gfx.DeviceDisplayInfo;
@Override
public void onConfigurationChanged(Configuration newConfig) {
updateDeviceDisplayInfo();
- mIdMap.get(mMainSdkDisplayId).updateFromDisplay(getDisplayFromContext(getContext()));
+ mIdMap.get(mMainSdkDisplayId).updateFromDisplay(
+ getDefaultDisplayForContext(getContext()));
}
@Override
@@ -183,7 +184,7 @@ import org.chromium.ui.gfx.DeviceDisplayInfo;
return sDisplayAndroidManager;
}
- /* package */ static Display getDisplayFromContext(Context context) {
+ /* package */ static Display getDefaultDisplayForContext(Context context) {
WindowManager windowManager =
(WindowManager) context.getSystemService(Context.WINDOW_SERVICE);
return windowManager.getDefaultDisplay();
@@ -210,7 +211,7 @@ import org.chromium.ui.gfx.DeviceDisplayInfo;
if (Build.VERSION.SDK_INT >= Build.VERSION_CODES.JELLY_BEAN_MR1) {
mBackend = new DisplayListenerBackendImpl();
} else {
- Display display = getDisplayFromContext(getContext());
+ Display display = getDefaultDisplayForContext(getContext());
mBackend = new DisplayListenerAPI16(display.getDisplayId());
addDisplay(display); // Note this display is never removed.
}
« no previous file with comments | « ui/android/java/src/org/chromium/ui/display/DisplayAndroid.java ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698